HDDS-15181. Added Robot smoketests for snapshot defrag on single-node compose #10200
+108
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| *** Settings *** | ||
| Documentation Basic checks that snapshots still look correct while the OM runs periodic | ||
| ... snapshot defrag in the background (Jira HDDS-15181 / parent HDDS-13003). | ||
| ... Cluster setup: filesystem snapshots on; defrag interval on the OM only | ||
| ... (compose/ozone docker-compose). | ||
| Library OperatingSystem | ||
| Resource ../ozone-lib/shell.robot | ||
| Resource snapshot-setup.robot | ||
| Suite Setup Prepare Suite With Bucket And First Snapshot | ||
| Test Timeout 20 minutes | ||
|
|
||
| *** Variables *** | ||
| # Wait long enough for at least two defrag runs (OM uses a 30s interval in compose). | ||
| ${DEFRAG_WAIT_SECONDS} 65 | ||
|
|
||
| *** Test Cases *** | ||
| Read Snapshot Data Right After Create | ||
| [Documentation] You can read the snapshotted key from the .snapshot path as soon as the snapshot exists. | ||
| Key Should Match Local File ${SNAP_KEY_PATH_ONE} /etc/hosts | ||
|
|
||
| After Waiting Keys Still Match Through Snapshot And On Live Bucket | ||
| [Documentation] Add a new key on the live bucket, wait so defrag may run, then confirm the snapshot | ||
| ... still has the old file and the live bucket has the new one. | ||
| ${key_two} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/passwd | ||
| Set Suite Variable ${KEY_TWO} ${key_two} | ||
| Set Suite Variable ${LIVE_KEY_TWO_PATH} /${VOLUME}/${BUCKET}/${key_two} | ||
| Sleep ${DEFRAG_WAIT_SECONDS} | ||
| Key Should Match Local File ${SNAP_KEY_PATH_ONE} /etc/hosts | ||
| Key Should Match Local File ${LIVE_KEY_TWO_PATH} /etc/passwd | ||
|
|
||
| Snapshot List Still Shows Active | ||
| [Documentation] ozone sh snapshot ls still lists this snapshot as SNAPSHOT_ACTIVE. | ||
| ${result} = Execute ozone sh snapshot ls /${VOLUME}/${BUCKET} | ||
| Should contain ${result} ${SNAPSHOT_ONE} | ||
| Should contain ${result} SNAPSHOT_ACTIVE | ||
|
|
||
| Second Snapshot Sees All Keys So Far | ||
| [Documentation] Take another snapshot after adding a third key; older snapshot still only has the first key; | ||
| ... newer snapshot can read all three keys. | ||
| ${key_three} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/group | ||
| Set Suite Variable ${KEY_THREE} ${key_three} | ||
| ${snapshot_two} = Create snapshot ${VOLUME} ${BUCKET} | ||
| Set Suite Variable ${SNAPSHOT_TWO} ${snapshot_two} | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_ONE}/${KEY_ONE} /etc/hosts | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_ONE} /etc/hosts | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_TWO} /etc/passwd | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_THREE} /etc/group | ||
|
|
||
| Snapshot Diff Starts A New Job | ||
| [Documentation] Comparing the two snapshots prints the usual “new job” and --get-report hint (like snapshot-sh.robot). | ||
| ${result} = Execute ozone sh snapshot diff /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO} | ||
| Should contain ${result} Submitting a new job | ||
| Should contain ${result} --get-report option | ||
|
|
||
| Snapshot Diff Json Report Lists Added Keys | ||
| [Documentation] Full JSON report finishes with DONE and lists the keys that appeared after the first snapshot. | ||
| ${result} = Execute ozone sh snapshot diff --get-report --json /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO} | ||
| Should contain echo '${result}' | jq '.jobStatus' DONE | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.volumeName' ${VOLUME} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.bucketName' ${BUCKET} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.fromSnapshot' ${SNAPSHOT_ONE} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.toSnapshot' ${SNAPSHOT_TWO} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_TWO} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_THREE} | ||
|
|
||
| Snapshot Diff Json Unchanged After Another Defrag Wait | ||
|
Contributor
There was a problem hiding this comment. Is the intention of this test to retrigger the snapshot diff? By default the result of snapshot diff is persisted for a while, so a rerun without clearing previous result won't actually retrigger the diff (see |
||
| [Documentation] Run the same JSON diff again after waiting again; the reported key paths should still be there. | ||
| Sleep ${DEFRAG_WAIT_SECONDS} | ||
|
Contributor
There was a problem hiding this comment. It can better confirm that defrag has been done by checking DB / yaml metadata. |
||
| ${result} = Execute ozone sh snapshot diff --get-report --json /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} ${SNAPSHOT_TWO} | ||
| Should contain echo '${result}' | jq '.jobStatus' DONE | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_TWO} | ||
| Should contain echo '${result}' | jq '.snapshotDiffReport.diffList | .[].sourcePath' ${KEY_THREE} | ||
|
|
||
| Delete Older Snapshot Younger One Still Readable | ||
| [Documentation] Delete the first snapshot; it shows SNAPSHOT_DELETED; read all keys through the second snapshot path. | ||
| ${output} = Execute ozone sh snapshot delete /${VOLUME}/${BUCKET} ${SNAPSHOT_ONE} | ||
| Should not contain ${output} Failed | ||
| ${output} = Execute ozone sh snapshot ls /${VOLUME}/${BUCKET} | jq '[.[] | select(.name == "${SNAPSHOT_ONE}") | .snapshotStatus] | if length > 0 then .[] else "SNAPSHOT_DELETED" end' | ||
| Should contain ${output} SNAPSHOT_DELETED | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_ONE} /etc/hosts | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_TWO} /etc/passwd | ||
| Key Should Match Local File /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${SNAPSHOT_TWO}/${KEY_THREE} /etc/group | ||
|
|
||
| *** Keywords *** | ||
| Prepare Suite With Bucket And First Snapshot | ||
| Setup volume and bucket | ||
| ${key_one} = snapshot-setup.Create key ${VOLUME} ${BUCKET} /etc/hosts | ||
| Set Suite Variable ${KEY_ONE} ${key_one} | ||
| ${snapshot_one} = Create snapshot ${VOLUME} ${BUCKET} | ||
| Set Suite Variable ${SNAPSHOT_ONE} ${snapshot_one} | ||
| Set Suite Variable ${SNAP_KEY_PATH_ONE} /${VOLUME}/${BUCKET}/${SNAPSHOT_INDICATOR}/${snapshot_one}/${key_one} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put this in ./compose/ozone/docker-config instead. e.g.:
https://github.com/arunsarin85/ozone/blob/aae498c66ef25c669854c203b1aa294825596fce/hadoop-ozone/dist/src/main/compose/ozone/docker-config#L44