HDDS-7956. Deprecate camelCase and under_score style long options#10495
Merged
Conversation
Contributor
|
Thanks @hani-fouladgar for the patch. This will have some conflict with #10494, so let's wait until that's merged. |
cbffada to
a71ff80
Compare
Contributor
|
Thanks again @hani-fouladgar for the patch. I've found that we can avoid splitting all options with deprecated alias to deprecated and non-deprecated pairs, yet still achieve our goals (of accepting deprecated options but not showing them in help). Currently working on HDDS-15596, please bear with me. |
Contributor
|
Please see #10542. After that change, this PR can be much simplified. |
Co-authored-by: Cursor <cursoragent@cursor.com>
d7032da to
2cb0772
Compare
adoroszlai
approved these changes
Jun 24, 2026
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @hani-fouladgar for updating the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Summary
This PR standardizes Ozone CLI long option names to kebab-case (
--max-size-to-move-per-iteration-in-gb) and deprecates legacy camelCase (--maxSizeToMovePerIterationInGB) and underscore (--column_family) variants.Core infrastructure
DeprecatedCliOptionsinhadoop-hdds/cli-commonwith shared helpers to:warning: --maxSizeToMovePerIterationInGB is deprecated, use --max-size-to-move-per-iteration-in-gb instead.@Optionfields for backward compatibility; canonical kebab-case options are shown in help.CLI commands updated
ozone debug ldb(scan/value schema), Ratis log parser, container-to-key mappingrandomkeys, Hadoop dir generators, SCM throughput benchmarkDocumentation
Backward compatibility
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7956
How was this patch tested?
TestContainerBalancerSubCommandverifying: