HDDS-15511. Implement Ozone client API's for bucket tagging#10533
Merged
Conversation
ivandika3
reviewed
Jun 20, 2026
ivandika3
left a comment
ivandika3
left a comment
Contributor
There was a problem hiding this comment.
@Gargi-jais11 Thanks for the patch. Overall LGTM. Left some comments.
ivandika3
approved these changes
Jun 30, 2026
ivandika3
left a comment
ivandika3
left a comment
Contributor
There was a problem hiding this comment.
@Gargi-jais11 Thanks for the update. LGTM +1.
It will be good to add S3 integration tests, but can be done in other patches.
Contributor
Author
Yes I will add all integration tests in the last PR once it's end to end done. |
Contributor
Author
|
Thanks @ivandika3 @chungen0126 for reviewing the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
getBucketTagging/putBucketTagging/deleteBucketTaggingon Ozone client with version gating.ClientProtocol.java / OzoneManagerProtocol.java— interface methodsOzoneManagerProtocolClientSideTranslatorPB.java— PB translationRpcClient.java— getBucketTagging, putBucketTagging, deleteBucketTagging with S3_BUCKET_TAGGING_API version gateOzoneBucket.java— public client APIOzoneRpcClientTests.javaintegration tests:- testPutBucketTagging (overwrite semantics)
- testGetBucketTagging
- testDeleteBucketTagging
- Parameterized across bucket layouts (LEGACY, FILE_SYSTEM_OPTIMIZED, OBJECT_STORE)
If we could introduce a base class for bucket tagging, or make delete request to derive put request.
the duplication between
S3PutBucketTaggingRequestand S3DeleteBucketTaggingRequestDiscussion link
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15511
How was this patch tested?
Added unit tests for 'OzoneRpcClientTests`.