Skip to content

HDDS-15609. Legacy SCM Finalize command should become a no-op#10543

Merged
sodonnel merged 4 commits into
apache:HDDS-14496-zdufrom
sodonnel:HDDS-15609
Jun 24, 2026
Merged

HDDS-15609. Legacy SCM Finalize command should become a no-op#10543
sodonnel merged 4 commits into
apache:HDDS-14496-zdufrom
sodonnel:HDDS-15609

Conversation

@sodonnel

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Now that finalization is driven from OM, the legacy SCM finalize command should become a no-op.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15609

How was this patch tested?

New unit test added.

@github-actions github-actions Bot added the zdu Pull requests for Zero Downtime Upgrade (ZDU) https://issues.apache.org/jira/browse/HDDS-14496 label Jun 18, 2026

@dombizita dombizita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on it @sodonnel!

@sodonnel

Copy link
Copy Markdown
Contributor Author

@errose28 - do you want another look?

@errose28 errose28 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need to fix the cleanup in the unit test so it doesn't break any new tests going forward. Otherwise LGTM.

@sodonnel sodonnel merged commit 21bc0e6 into apache:HDDS-14496-zdu Jun 24, 2026
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zdu Pull requests for Zero Downtime Upgrade (ZDU) https://issues.apache.org/jira/browse/HDDS-14496

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants