HDDS-15622. New finalize command should check OM server version#10548
Open
sodonnel wants to merge 2 commits into
Open
HDDS-15622. New finalize command should check OM server version#10548sodonnel wants to merge 2 commits into
sodonnel wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
zdu
dombizita
approved these changes
Jun 22, 2026
dombizita
left a comment
dombizita
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, one minor nit about a log message.
…dmin/upgrade/FinalizeSubCommand.java Co-authored-by: Zita Dombi <50611074+dombizita@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The new upgrade commands (only finalize for now) should check the OM version is ZDU ready, otherwise fail with a helpful error.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15622
How was this patch tested?
New unit test