HDDS-15582. Skip performance test of unused batchDeleteSCMStatesForContainers#10551
Merged
Conversation
adoroszlai
changed the title
Contributor
Author
|
@devmadhuu please take a look |
devmadhuu
approved these changes
Jun 23, 2026
devmadhuu
left a comment
devmadhuu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai for the patch. LGTM +1.
Contributor
Author
|
Thanks @devmadhuu for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerHealthSchemaManager.batchDeleteSCMStatesForContainersis only called from tests, production code usesreplaceUnhealthyContainerRecordsAtomicallyinstead. This PR disablesTestUnhealthyContainersDerbyPerformancetest case forbatchDeleteSCMStatesForContainers(and follow-uptestCountByStateAfterFullDelete) in CI to save time. The test can still be run locally.https://issues.apache.org/jira/browse/HDDS-15582
How was this patch tested?
Before:
After:
https://github.com/adoroszlai/ozone/actions/runs/27824224044/job/82350278873#step:13:3745