HDDS-13877. Fix and tweak Apple silicon protobuf 2.5.0 build section

[smengcl]

What changes were proposed in this pull request?

There is a cd .. command that is not necessary. Fixed in HDDS-13931

The file modification step can be more streamlined. Along with other tweaks and fixes.

Note: Ozone 2.2.0 and on will not need the protobuf 2.5.0 build steps because protobuf 2.5.0 is no longer a dependency. Ozone 2.1.x and earlier will still need this step for devs.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13877

How was this patch tested?

• Tested manually on a fresh M4 MacBook Air.

[Copilot]

Pull Request Overview

This PR simplifies and improves the documentation for building Ozone from source on ARM-based Apple Silicon Macs. The main focus is on streamlining the protobuf 2.5.0 setup process for macOS ARM64 systems.

• Automated the protobuf patching process by replacing manual file editing with a sed command
• Removed the PROTOBUF_VERSION variable in favor of hardcoded version strings for consistency with other sections
• Updated terminology and processor model references

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[errose28]

Is this intended to match the steps on the new website?

[adoroszlai]

Thanks @smengcl for the fix. Unnecessary cd .. has been removed in HDDS-13931 as a simple targeted fix. This PR can be updated for the remaining improvements.

I agree with @bdemers suggestion in #9295: sed is better than manual edits, but patch is even better.

[github-actions]

This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.

[smengcl]

Is this intended to match the steps on the new website?

ah yup, that needs to be updated as well. Will file another PR for that. Thanks for the reminder.

[smengcl]

Thanks @smengcl for the fix. Unnecessary cd .. has been removed in HDDS-13931 as a simple targeted fix. This PR can be updated for the remaining improvements.

I agree with @bdemers suggestion in #9295: sed is better than manual edits, but patch is even better.

I like the idea. I have replaced sed with an inline patch. ptal.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[smengcl]

Would you like to take a look @adoroszlai ?

[adoroszlai]

Thanks @smengcl for updating the doc, LGTM. Steps for downloading and patching protobuf worked fine.

This reminds me: Protobuf 2.5 is no longer used on master, but it could be useful when working with backports or releases before 2.2.

[jojochuang]

Let's update the v2 doc and remove the protobuf 2.5 instructions there.
v1 doc will soon be deprecated (hopefully this time for real)

[smengcl]

Let's update the v2 doc and remove the protobuf 2.5 instructions there. v1 doc will soon be deprecated (hopefully this time for real)

We still need this for Ozone 2.1 dev. It is no longer necessary from 2.2 and onwards.

[smengcl]

Thanks @jojochuang @adoroszlai for reviewing this.