Skip to content

HDDS-13877. Fix and tweak Apple silicon protobuf 2.5.0 build section #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 7 commits into from
Dec 11, 2025
+24 −13
Merged

HDDS-13877. Fix and tweak Apple silicon protobuf 2.5.0 build section #9242

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5105c6
HDDS-13877. Fix and tweak Apple silicon protobuf 2.5.0 build section
smengcl Nov 3, 2025
d8c2eab
Update hadoop-hdds/docs/content/start/FromSource.md
smengcl Nov 3, 2025
9a6799c
Merge remote-tracking branch 'asf' into HDDS-13877-doc
smengcl Dec 9, 2025
7ecc193
Take comment suggestion from Wei-Chiu
smengcl Dec 9, 2025
9d01a80
Use patch instead of sed
smengcl Dec 9, 2025
aeb6724
Update subtitle
smengcl Dec 9, 2025
7cf14e5
Doesn't hurt to add `-p1`
smengcl Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions hadoop-hdds/docs/content/start/FromSource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,29 +66,40 @@ mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dver
cp $HOME/.m2/repository/com/google/protobuf/protoc/2.5.0/protoc-2.5.0-linux-aarch_64 $HOME/.m2/repository/com/google/protobuf/protoc/2.5.0/protoc-2.5.0-linux-aarch_64.exe
```

## ARM-based Apple Silicon (Apple M1 ... etc)
## ARM-based Apple silicon (Apple M1, M2, etc.)

```bash
# Patch protobuf 2.5.0 - this is needed for Hadoop 2 support
PROTOBUF_VERSION="2.5.0"
curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v2.5.0/protobuf-2.5.0.tar.gz
tar xzf protobuf-2.5.0.tar.gz
pushd protobuf-${PROTOBUF_VERSION}

# Open the file `src/google/protobuf/stubs/platform_macros.h` with an editor like vim and append the following lines after line 59 (include the #).
# Save the file when complete.

#elif defined(__arm64__)
#define GOOGLE_PROTOBUF_ARCH_ARM 1
#define GOOGLE_PROTOBUF_ARCH_64_BIT 1
pushd protobuf-2.5.0

# Patch to insert arm64 macro
patch -p1 << EOF
diff --git a/src/google/protobuf/stubs/platform_macros.h b/src/google/protobuf/stubs/platform_macros.h
index b1df60e..8a68655 100644
--- a/src/google/protobuf/stubs/platform_macros.h
+++ b/src/google/protobuf/stubs/platform_macros.h
@@ -57,6 +57,9 @@
#elif defined(__ppc__)
#define GOOGLE_PROTOBUF_ARCH_PPC 1
#define GOOGLE_PROTOBUF_ARCH_32_BIT 1
+#elif defined(__arm64__)
+#define GOOGLE_PROTOBUF_ARCH_ARM 1
+#define GOOGLE_PROTOBUF_ARCH_64_BIT 1
#else
#error Host architecture was not detected as supported by protobuf
#endif
EOF

# Execute the following commands to build `protoc`
./configure --disable-shared
make -j

Comment thread
smengcl marked this conversation as resolved.
# Install protoc to the local Maven repository
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=${PROTOBUF_VERSION} -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=src/protoc
# Workaround for Maven 3.9.x. Not needed for 3.8.x or earlier
mv $HOME/.m2/repository/com/google/protobuf/protoc/${PROTOBUF_VERSION}/protoc-${PROTOBUF_VERSION}-osx-aarch_64 $HOME/.m2/repository/com/google/protobuf/protoc/${PROTOBUF_VERSION}/protoc-${PROTOBUF_VERSION}-osx-aarch_64.exe
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=src/protoc
# Workaround for Maven 3.9.x. Not needed for 3.8.x and earlier
mv $HOME/.m2/repository/com/google/protobuf/protoc/2.5.0/protoc-2.5.0-osx-aarch_64 $HOME/.m2/repository/com/google/protobuf/protoc/2.5.0/protoc-2.5.0-osx-aarch_64.exe
popd
```

Expand Down