HDDS-13466. Intermittent timeout in TestOmSnapshot#9471
Merged
adoroszlai merged 3 commits intoapache:masterfrom Dec 12, 2025
Merged
HDDS-13466. Intermittent timeout in TestOmSnapshot#9471adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
Change-Id: Ia1bb3f9bdd199bf7c652b25f158556c8b0b24c10
Contributor
|
Please run flaky-test-check in your fork for |
Contributor
Author
Contributor
Thanks, this looks promising. However, it looks like |
Contributor
Author
|
Any idea how I can trigger the native build in the framework? |
Contributor
Adding |
Change-Id: I712916db194af2f906fad8bbfc130093cbc6a928
Contributor
Author
Contributor
Author
|
The previous run timed out after 6 hours https://github.com/swamirishi/ozone/actions/runs/20133765218/job/57781800484 |
Contributor
Author
|
@adoroszlai the splits passed can this be merged? |
adoroszlai
changed the title
adoroszlai
reviewed
Dec 11, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @swamirishi for the fix.
| - name: Build (most) of Ozone | ||
| run: | | ||
| args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true" | ||
| args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true ${{ github.event.inputs.maven_additional_args }}" |
Contributor
There was a problem hiding this comment.
Instead of the generic "additional args" I'd prefer adding -Drocks_tools_native to match normal integration check.
Suggested change
| args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true ${{ github.event.inputs.maven_additional_args }}" | |
| args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true -Drocks_tools_native" |
| fi | ||
|
|
||
| args="-DexcludedGroups=native|slow|unhealthy -DskipShade" | ||
| args="-DexcludedGroups=native|slow|unhealthy -DskipShade ${{ github.event.inputs.maven_additional_args }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| args="-DexcludedGroups=native|slow|unhealthy -DskipShade ${{ github.event.inputs.maven_additional_args }}" | |
| args="-DexcludedGroups=slow|unhealthy -DskipShade -Drocks_tools_native" |
Comment on lines
+23
to
+26
| maven_additional_args: | ||
| description: Additional Maven build arguments | ||
| default: '' | ||
| required: false |
Contributor
There was a problem hiding this comment.
Suggested change
| maven_additional_args: | |
| description: Additional Maven build arguments | |
| default: '' | |
| required: false |
Change-Id: Iee168bb4eeb16351d52062f027ddeaf51888c633
Contributor
Author
|
@adoroszlai can I merge this? |
adoroszlai
approved these changes
Dec 12, 2025
Contributor
|
Thanks @swamirishi for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix OmSnapshotTest to close snapshots in snapshot cache every 100 ms to ensure too many files are not open. Fix individual test to also close all snapshots opened in the test to ensure miniozone cluster shuts down correctly
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13466
How was this patch tested?
Fixing existing tests