HDDS-14117. Add nonStreamRead and fileRead cases to tests.#9476
Merged
sodonnel merged 2 commits intoapache:masterfrom Dec 22, 2025
Merged
HDDS-14117. Add nonStreamRead and fileRead cases to tests.#9476sodonnel merged 2 commits intoapache:masterfrom
sodonnel merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thanks for the patch @szetszwo ! |
Contributor
|
It seems a dead code. |
rich7420
suggested changes
Dec 19, 2025
Comment on lines
268
to
269
| for (long pos = 0; pos < keySizeByte;) { | ||
| final int writeSize = Math.toIntExact(Math.min(buffer.length, keySizeByte - pos)); |
Contributor
There was a problem hiding this comment.
Suggested change
| for (long pos = 0; pos < keySizeByte;) { | |
| final int writeSize = Math.toIntExact(Math.min(buffer.length, keySizeByte - pos)); |
Comment on lines
270
to
271
| pos += writeSize; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| pos += writeSize; | |
| } |
Contributor
|
overall LGTM! |
Contributor
Author
|
@rich7420 , thanks for reviewing this! Just have pushed a commit to address your comments. |
Contributor
|
thanks @szetszwo for the update! |
rich7420
approved these changes
Dec 20, 2025
sodonnel
approved these changes
Dec 22, 2025
Contributor
Author
Contributor
echonesis
pushed a commit
to echonesis/ozone
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For comparison, we add nonStreamRead and fileRead cases to TestStreamRead.
What is the link to the Apache JIRA
HDDS-14117
How was this patch tested?
This is adding new test cases.