HDDS-14122. Make OmKeyInfo ACL list immutable#9486
Merged
adoroszlai merged 2 commits intoapache:masterfrom Dec 13, 2025
Merged
Conversation
adoroszlai
reviewed
Dec 12, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @echonesis for the patch.
Comment on lines
100
to
-102
| // Reverting back the full path to key name | ||
| // Eg: a/b/c/d/e/file1 -> file1 | ||
| omKeyInfo.setKeyName(OzoneFSUtils.getFileName(key)); |
Contributor
There was a problem hiding this comment.
nit: Please also move the comment.
| omKeyInfo.appendNewBlocks(allocatedLocationList, false); | ||
| List<OzoneAcl> acls = Collections.singletonList(OzoneAcl.parseAcl("user:foo:rw")); | ||
| omKeyInfo.addAcl(acls.get(0)); | ||
| omKeyInfo = omKeyInfo.toBuilder().addAcl(acls.get(0)).build(); |
Contributor
There was a problem hiding this comment.
Please addAcl on omKeyInfoBuilder before:
adoroszlai
approved these changes
Dec 12, 2025
Contributor
Author
|
Thanks @adoroszlai for the review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid in-place mutation of ACL list in OmKeyInfo.
Reference PR: #9466
OmKeyInfo.Builderto useAclListBuilder.OmKeyInfo#aclstoImmutableList.applymethod in each Request to useOmKeyInfo.Builderinstead ofOmKeyInfo.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14122
How was this patch tested?
GitHub Actions CI: https://github.com/echonesis/ozone/actions/runs/20158237612