HDDS-13895. Refactor OzoneManager.installCheckpoint()#9490
Closed
rich7420 wants to merge 7 commits intoapache:masterfrom
Closed
HDDS-13895. Refactor OzoneManager.installCheckpoint()#9490rich7420 wants to merge 7 commits intoapache:masterfrom
rich7420 wants to merge 7 commits intoapache:masterfrom
Conversation
chungen0126
reviewed
Jan 5, 2026
Contributor
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @rich7420 for the patch. Could you please also move OzoneManager#installCheckpoint into the new class?
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
Contributor
Author
|
@chungen0126 ok, sorry I missed that message. |
393a02a to
ebaae8c
Compare
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactored installCheckpoint() in OzoneManager.java. I moved it into /om/ratis_snapshot because I noticed its a part of bootstrapping installSnapshot. If it's wrong please correct me, thanks!
What is the link to the Apache JIRA
HDDS-13895
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/20160105743