HDDS-14176. Do not use Optional for volumeUsage#9503
Merged
szetszwo merged 1 commit intoapache:masterfrom Dec 15, 2025
Merged
Conversation
adoroszlai
added
the
code-cleanup
szetszwo
approved these changes
Dec 15, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for reviewing and merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid using
OptionalforStorageVolume#volumeUsage, and some minor improvements in the code being touched.VolumeUsage#isReservedUsagesInRangeso that we can combine two separate warnings, both of which had only half of the relevant information.checkVolumeUsagesfor consistency between check and log message.https://issues.apache.org/jira/browse/HDDS-14176
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/20226487252