Skip to content

HDDS-14200. Make request context available in all endpoints#9519

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14200
Dec 18, 2025
Merged

HDDS-14200. Make request context available in all endpoints#9519
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14200

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Pull up into EndpointBase:

  • ContainerRequestContext
  • HttpHeaders
  • OzoneConfiguration

Benefits:

  • reduces duplication
  • no need for specific endpoint builders
  • mock path/query parameters can be set up in EndpointBuilder

https://issues.apache.org/jira/browse/HDDS-14200

How was this patch tested?

Ran S3 unit and integration tests locally.

CI (in progress):
https://github.com/adoroszlai/ozone/actions/runs/20318134724

@adoroszlai adoroszlai self-assigned this Dec 17, 2025
@adoroszlai adoroszlai added the s3 S3 Gateway label Dec 17, 2025
@adoroszlai adoroszlai marked this pull request as ready for review December 17, 2025 23:02
Copy link
Copy Markdown
Member

@peterxcli peterxcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1, thanks for this clean-up

Copy link
Copy Markdown
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1.

@adoroszlai adoroszlai merged commit 609399a into apache:master Dec 18, 2025
55 checks passed
@adoroszlai adoroszlai deleted the HDDS-14200 branch December 18, 2025 06:50
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @ivandika3, @peterxcli for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3 S3 Gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants