Skip to content

HDDS-14203. Use EndpointBuilder in all S3G unit tests#9522

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14203
Dec 18, 2025
Merged

HDDS-14203. Use EndpointBuilder in all S3G unit tests#9522
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:HDDS-14203

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Some S3G unit tests still create BucketEndpoint/ObjectEndpoint directly. Change these to use EndpointBuilder.
  • Builder should initialize() endpoints after creation so that tests do not need to. Some tests that use mock ObjectStore need additional mocking for this.
  • Rename BucketEndpoint getBucket to endpoint in TestBucketList, since this class is already being changed for using the builder.

Note that this is a test-only change.

https://issues.apache.org/jira/browse/HDDS-14203

How was this patch tested?

Ran checkstyle and all S3G unit tests locally.

CI (in progress):
https://github.com/adoroszlai/ozone/actions/runs/20330654241

Copy link
Copy Markdown
Member

@peterxcli peterxcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@adoroszlai adoroszlai merged commit a5d44be into apache:master Dec 18, 2025
55 of 56 checks passed
@adoroszlai adoroszlai deleted the HDDS-14203 branch December 18, 2025 14:54
@adoroszlai
Copy link
Copy Markdown
Contributor Author

Thanks @peterxcli for the review.

echonesis pushed a commit to echonesis/ozone that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3 S3 Gateway test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants