HDDS-14204. Reduce duplication in auditing S3G requests#9524
Merged
peterxcli merged 1 commit intoapache:masterfrom Dec 18, 2025
Merged
HDDS-14204. Reduce duplication in auditing S3G requests#9524peterxcli merged 1 commit intoapache:masterfrom
peterxcli merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
added
s3
Member
|
Thanks @adoroszlai for this patch! |
Contributor
Author
|
Thanks @peterxcli for reviewing and merging this. |
echonesis
pushed a commit
to echonesis/ozone
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
EndpointBasehas methods to simplify auditing failures in subclasses, but:SUCCESScase is not coveredThis PR adds the missing
auditReadSuccessandauditWriteSuccess, and changes all calls to use the simplified methods, exceptBucketEndpoint#multiDelete, which needs to add extra params for the message.Also:
AuditMessage.Builderfrom the helper methods to allow further customization of the message (addperf, etc.), thus reduce duplication.getAuditParameters()call intoauditMessageBaseBuilder, renamed toauditMessageFor.https://issues.apache.org/jira/browse/HDDS-14204
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/20336484273 (in progress)
https://github.com/adoroszlai/ozone/actions/runs/20334289695 (mostly OK)