HDDS-14208. Create constants for query parameter names#9525
Merged
adoroszlai merged 1 commit intoapache:masterfrom Dec 19, 2025
Merged
HDDS-14208. Create constants for query parameter names#9525adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
added
s3
rich7420
reviewed
Dec 19, 2025
| .header("Content-Length", key.getDataSize()) | ||
| .header("Content-Type", "binary/octet-stream") | ||
| .header(HttpHeaders.CONTENT_LENGTH, key.getDataSize()) | ||
| .header(HttpHeaders.CONTENT_TYPE, "binary/octet-stream") |
Contributor
There was a problem hiding this comment.
nit: should we consider extracting "binary/octet-stream" to a constant in S3Consts for consistency with the refactoring?
Contributor
There was a problem hiding this comment.
just a question, overall LGTM
Contributor
Author
There was a problem hiding this comment.
Good point, I'll include it in the next patch.
Contributor
Author
|
Thanks @ivandika3, @peterxcli, @rich7420 for the review. |
Contributor
|
thanks @adoroszlai ! |
echonesis
pushed a commit
to echonesis/ozone
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
@QueryParamvalues toS3Consts.QueryParams.@PathParamvalues to the endpoint class, because these depend on the@Pathfrom the same class.HttpHeadersfor@HeaderParamvalues. Some were already used as static imports, replace them with qualified access for clarity and consistency.OzoneConsts.ETAGvs.HttpHeaders.ETAGfor metadata vs. header purposes. BTW the two values are the same.https://issues.apache.org/jira/browse/HDDS-14208
How was this patch tested?
Ran all S3 unit tests locally.
CI:
https://github.com/adoroszlai/ozone/actions/runs/20345474287