HDDS-14211. Extract base RDBBatchOperation, rename implementation to AtomicRDBBatchOperation#9526
HDDS-14211. Extract base RDBBatchOperation, rename implementation to AtomicRDBBatchOperation#9526swamirishi wants to merge 5 commits intoapache:masterfrom
Conversation
…ntroduce base abstract class RDBBatchOperation Change-Id: Ia81bd22e402fb8e96a613760bce9fd97ac51d849
|
@adoroszlai I renamed the class here the diff ideally should only do rename RDBBatchOperation -> AtomicRDBBatchOperation and then create a new RDBBatchOperation class |
|
This PR should not introduce the new base class, nor touch
( |
|
Created #9545 for the factory method. After that, this PR can focus on renaming |
| */ | ||
| public final class RDBBatchOperation implements BatchOperation { | ||
| static final Logger LOG = LoggerFactory.getLogger(RDBBatchOperation.class); | ||
| public abstract class RDBBatchOperation implements BatchOperation { |
There was a problem hiding this comment.
Can RDBBatchOperation be an interface instead of abstract class? (It was one in #9511.)
There was a problem hiding this comment.
It can be only abstact classes since interfaces don't allow package private methods. The methods should not be exposed outside the db package
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it. |
What changes were proposed in this pull request?
Rename RDBBatchOperation as AtomicRDBBatchOperation and introduce base abstract class RDBBatchOperation
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14211
How was this patch tested?
Just refactoring no additional tests required