HDDS-14194. Make streaming write SYNC configurable#9533
Merged
ivandika3 merged 1 commit intoapache:masterfrom Dec 27, 2025
Merged
HDDS-14194. Make streaming write SYNC configurable#9533ivandika3 merged 1 commit intoapache:masterfrom
ivandika3 merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
thanks for the patch @ivandika3 ! |
rich7420
approved these changes
Dec 20, 2025
szetszwo
approved these changes
Dec 26, 2025
Contributor
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo @rich7420 for the reviews. In the future, we might either change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See BlockDataStreamOutput#needSync, currently SYNC is never used and therefore we might not be sure when the data is actually flushed to the disk (see StreamDataChannelBase#force which will invoke FileChannel#force(false) to flush the data to the underlying storage)
We can create a configuration to allow SYNC, which is disabled by default to preserve compatibility.
We also might want to revisit whether we should make SYNC to be a client-side or server-side. The concern is if a client is misconfigured, it might cause a lot of sync on the DN which will cause higher latencies.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14194
How was this patch tested?