HDDS-14334. Fix JMX query failures when hdds.datanode.http.auth.type is set to Kerberos#9577
Merged
Merged
Conversation
ChenSammi
approved these changes
Jan 5, 2026
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @priyeshkaratha .
priyeshkaratha
changed the title
Contributor
|
Thanks @priyeshkaratha for the patch. Why is this marked as "DO NOT MERGE"? |
Contributor
Author
|
@adoroszlai current code is not setting security context properly. I just updated the PR with changes and tested in one of the ycloud cluster. |
priyeshkaratha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, JmxServiceProviderImpl fails to fetch JMX metrics when Datanodes are configured with Kerberos authentication. This occurs because the ReconUtils#makeHttpCall method is invoked without the isSpnego flag set to true, causing authentication to fail.
This PR introduces a check for the hdds.datanode.http.auth.type configuration property. If set to kerberos, the service will now correctly pass isSpnego = true to ReconUtils, ensuring secure JMX communication.
What is the link to the Apache JIRA
HDDS-14334
How was this patch tested?
Validated with CI