[spark] Support Nan check in SparkFilterConverter#7590
Closed
xuzifu666 wants to merge 3 commits intoapache:masterfrom
Closed
[spark] Support Nan check in SparkFilterConverter#7590xuzifu666 wants to merge 3 commits intoapache:masterfrom
xuzifu666 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
Spark SQL does NOT follow IEEE 754 for NaN equality. In Spark, NaN = NaN evaluates to true: So WHERE float_col = float('NaN') should return rows where float_col IS NaN. Returning alwaysFalse() silently drops those rows — this is a data correctness bug. |
Member
Author
Thanks for the reminder！There was indeed a data issue with this change, and it seems unnecessary. I'll close this PR. @JingsongLi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
NaN (Not a Number) is a special value defined in the IEEE 754 floating-point standard. The concept of NaN only exists for floating-point numbers（Double/Float）, including in Spark SQL. This pr aim to resolve the unfinished issue.
Tests