Skip to content

[lumina] Rename index identifier lumina-vector-ann to `lumina#7707

Merged
JingsongLi merged 4 commits intoapache:masterfrom
jerry-024:lumina_rename
Apr 27, 2026
Merged

[lumina] Rename index identifier lumina-vector-ann to `lumina#7707
JingsongLi merged 4 commits intoapache:masterfrom
jerry-024:lumina_rename

Conversation

@jerry-024
Copy link
Copy Markdown
Contributor

@jerry-024 jerry-024 commented Apr 27, 2026

Purpose

Rename the Lumina vector global index identifier from lumina-vector-ann to
lumina for a cleaner, shorter name. Existing tables created with the old
identifier continue to work via a LegacyLuminaVectorGlobalIndexerFactory
registered through SPI, so no on-disk migration is required. File naming on
disk is unchanged (the writer has always used the lumina- prefix).

Tests

  • LuminaVectorGlobalIndexerFactoryTest — verifies both identifiers route to
    the correct factory class.
  • IndexFileHandlerTest#testExistsAndDeleteIndexFile — parameterized over both
    lumina and lumina-vector-ann.
  • FileTypeTest#testGlobalIndexFiles — adds the new lumina-global-index-*
    path to the classification check.
  • LuminaVectorIndexTest (Spark) — adds a "create lumina vector index - legacy
    index type" case using lumina-vector-ann.
  • vector_search_filter_test.VectorReaderFactoryTest — Python reader accepts
    both identifiers.

@jerry-024 jerry-024 marked this pull request as draft April 27, 2026 04:59
@jerry-024 jerry-024 changed the title [index]fix: lumina name change to lumina [lumina] Rename index identifier lumina-vector-ann to `lumina Apr 27, 2026
@jerry-024 jerry-024 marked this pull request as ready for review April 27, 2026 10:24
Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit dd2273f into apache:master Apr 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants