PARQUET-2406: Clean up valueOf calls where possible (#1229)

Author: amousavigourabi

parquet-avro/src/main/java/org/apache/parquet/avro/AvroIndexedRecordConverter.java

@@ -168,7 +168,7 @@ private static Converter newConverter(Schema schema, Type type, GenericData mode
       case MAP:
         return new MapConverter(parent, type.asGroupType(), schema, model);
       case RECORD:
-        return new AvroIndexedRecordConverter(parent, type.asGroupType(), schema, model);
+        return new AvroIndexedRecordConverter<>(parent, type.asGroupType(), schema, model);
       case STRING:
         return new AvroConverters.FieldStringConverter(parent);
       case UNION:
@@ -260,7 +260,7 @@ static final class FieldFixedConverter extends PrimitiveConverter {
     private final ParentValueContainer parent;
     private final Schema avroSchema;
     private final Class<? extends GenericData.Fixed> fixedClass;
-    private final Constructor fixedClassCtor;
+    private final Constructor<? extends Object> fixedClassCtor;
 
     public FieldFixedConverter(ParentValueContainer parent, Schema avroSchema, GenericData model) {
       this.parent = parent;

parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java

@@ -156,7 +156,7 @@ public RecordMaterializer<T> prepareForRead(
 
     GenericData model = getDataModel(configuration, avroSchema);
     String compatEnabled = metadata.get(AvroReadSupport.AVRO_COMPATIBILITY);
-    if (compatEnabled != null && Boolean.valueOf(compatEnabled)) {
+    if (Boolean.parseBoolean(compatEnabled)) {
       return newCompatMaterializer(parquetSchema, avroSchema, model);
     }
     return new AvroRecordMaterializer<T>(parquetSchema, avroSchema, model);

parquet-cli/src/main/java/org/apache/parquet/cli/csv/AvroCSV.java

@@ -108,7 +108,7 @@ private static Schema inferSchemaInternal(
       Objects.requireNonNull(line, "No content to infer schema");
       header = new String[line.length];
       for (int i = 0; i < line.length; i += 1) {
-        header[i] = "field_" + String.valueOf(i);
+        header[i] = "field_" + i;
       }
     }
 

parquet-cli/src/main/java/org/apache/parquet/cli/csv/CSVProperties.java

@@ -63,7 +63,7 @@ public static class Builder {
     private String delimiter = DEFAULT_DELIMITER;
     private String quote = DEFAULT_QUOTE;
     private String escape = DEFAULT_ESCAPE;
-    private boolean useHeader = Boolean.valueOf(DEFAULT_HAS_HEADER);
+    private boolean useHeader = Boolean.parseBoolean(DEFAULT_HAS_HEADER);
     private int linesToSkip = DEFAULT_LINES_TO_SKIP;
     private String header = null;
 

parquet-cli/src/main/java/org/apache/parquet/cli/json/AvroJson.java

@@ -212,10 +212,7 @@ private static Object convertField(GenericData model, JsonNode datum, Schema.Fie
       throw new RecordException(String.format("Cannot convert field %s", field.name()), e);
     } catch (AvroRuntimeException e) {
       throw new RecordException(
-          String.format(
-              "Field %s: cannot make %s value: '%s'",
-              field.name(), field.schema(), String.valueOf(datum)),
-          e);
+          String.format("Field %s: cannot make %s value: '%s'", field.name(), field.schema(), datum), e);
     }
   }
 

parquet-column/src/main/java/org/apache/parquet/column/values/dictionary/DictionaryValuesWriter.java

@@ -226,10 +226,7 @@ public void resetDictionary() {
   public String memUsageString(String prefix) {
     return String.format(
         "%s DictionaryValuesWriter{\n" + "%s\n" + "%s\n" + "%s}\n",
-        prefix,
-        prefix + " dict:" + dictionaryByteSize,
-        prefix + " values:" + String.valueOf(encodedValues.size() * 4),
-        prefix);
+        prefix, prefix + " dict:" + dictionaryByteSize, prefix + " values:" + encodedValues.size() * 4, prefix);
   }
 
   public static class PlainBinaryDictionaryValuesWriter extends DictionaryValuesWriter {

parquet-column/src/main/java/org/apache/parquet/example/data/simple/Int96Value.java

@@ -41,6 +41,6 @@ public void writeValue(RecordConsumer recordConsumer) {
 
   @Override
   public String toString() {
-    return "Int96Value{" + String.valueOf(value) + "}";
+    return "Int96Value{" + value + "}";
   }
 }

parquet-common/src/main/java/org/apache/parquet/SemanticVersion.java

@@ -103,9 +103,9 @@ public static SemanticVersion parse(String version) throws SemanticVersionParseE
     final int patch;
 
     try {
-      major = Integer.valueOf(matcher.group(1));
-      minor = Integer.valueOf(matcher.group(2));
-      patch = Integer.valueOf(matcher.group(3));
+      major = Integer.parseInt(matcher.group(1));
+      minor = Integer.parseInt(matcher.group(2));
+      patch = Integer.parseInt(matcher.group(3));
     } catch (NumberFormatException e) {
       throw new SemanticVersionParseException(e);
     }

parquet-hadoop/src/main/java/org/apache/parquet/ParquetReadOptions.java

@@ -212,7 +212,7 @@ public FileDecryptionProperties getDecryptionProperties() {
 
   public boolean isEnabled(String property, boolean defaultValue) {
     Optional<String> propValue = Optional.ofNullable(properties.get(property));
-    return propValue.isPresent() ? Boolean.valueOf(propValue.get()) : defaultValue;
+    return propValue.map(Boolean::parseBoolean).orElse(defaultValue);
   }
 
   public ParquetConfiguration getConfiguration() {

parquet-hadoop/src/main/java/org/apache/parquet/crypto/keytools/KeyMaterial.java

@@ -171,7 +171,7 @@ static String createSerialized(
       keyMaterialMap.put(KeyMetadata.KEY_MATERIAL_INTERNAL_STORAGE_FIELD, Boolean.TRUE);
     }
     // 2. Write isFooterKey
-    keyMaterialMap.put(IS_FOOTER_KEY_FIELD, Boolean.valueOf(isFooterKey));
+    keyMaterialMap.put(IS_FOOTER_KEY_FIELD, isFooterKey);
     if (isFooterKey) {
       // 3. For footer key, write KMS Instance ID
       keyMaterialMap.put(KMS_INSTANCE_ID_FIELD, kmsInstanceID);
@@ -183,7 +183,7 @@ static String createSerialized(
     // 6. Write wrapped DEK
     keyMaterialMap.put(WRAPPED_DEK_FIELD, encodedWrappedDEK);
     // 7. Write isDoubleWrapped
-    keyMaterialMap.put(DOUBLE_WRAPPING_FIELD, Boolean.valueOf(isDoubleWrapped));
+    keyMaterialMap.put(DOUBLE_WRAPPING_FIELD, isDoubleWrapped);
     if (isDoubleWrapped) {
       // 8. In double wrapping mode, write KEK ID
       keyMaterialMap.put(KEK_ID_FIELD, kekID);