Skip to content

Commit 215817e

Browse files
committed
address review comments
1 parent 63b6762 commit 215817e

3 files changed

Lines changed: 6 additions & 28 deletions

File tree

parquet-cli/src/main/java/org/apache/parquet/cli/Main.java

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,7 @@
3434
import org.apache.hadoop.util.ToolRunner;
3535
import org.apache.log4j.Level;
3636
import org.apache.log4j.PropertyConfigurator;
37-
import org.apache.parquet.cli.commands.CSVSchemaCommand;
38-
import org.apache.parquet.cli.commands.CatCommand;
39-
import org.apache.parquet.cli.commands.CheckParquet251Command;
40-
import org.apache.parquet.cli.commands.ColumnMaskingCommand;
41-
import org.apache.parquet.cli.commands.ColumnSizeCommand;
42-
import org.apache.parquet.cli.commands.ConvertCSVCommand;
43-
import org.apache.parquet.cli.commands.ConvertCommand;
44-
import org.apache.parquet.cli.commands.ParquetMetadataCommand;
45-
import org.apache.parquet.cli.commands.PruneColumnsCommand;
46-
import org.apache.parquet.cli.commands.RewriteCommand;
47-
import org.apache.parquet.cli.commands.ScanCommand;
48-
import org.apache.parquet.cli.commands.SchemaCommand;
49-
import org.apache.parquet.cli.commands.ShowBloomFilterCommand;
50-
import org.apache.parquet.cli.commands.ShowColumnIndexCommand;
51-
import org.apache.parquet.cli.commands.ShowDictionaryCommand;
52-
import org.apache.parquet.cli.commands.ShowFooterCommand;
53-
import org.apache.parquet.cli.commands.ShowGeospatialStatisticsCommand;
54-
import org.apache.parquet.cli.commands.ShowPagesCommand;
55-
import org.apache.parquet.cli.commands.ShowSizeStatisticsCommand;
56-
import org.apache.parquet.cli.commands.ToAvroCommand;
57-
import org.apache.parquet.cli.commands.TransCompressionCommand;
37+
import org.apache.parquet.cli.commands.*;
5838
import org.slf4j.Logger;
5939
import org.slf4j.LoggerFactory;
6040

parquet-cli/src/main/java/org/apache/parquet/cli/ShowVersionCommand.java renamed to parquet-cli/src/main/java/org/apache/parquet/cli/commands/ShowVersionCommand.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,20 @@
1616
* specific language governing permissions and limitations
1717
* under the License.
1818
*/
19-
package org.apache.parquet.cli;
19+
package org.apache.parquet.cli.commands;
2020

21-
import com.beust.jcommander.*;
21+
import com.beust.jcommander.Parameters;
2222
import java.util.Collections;
2323
import java.util.List;
2424
import org.apache.parquet.Version;
25+
import org.apache.parquet.cli.BaseCommand;
2526
import org.slf4j.Logger;
2627

2728
@Parameters(commandDescription = "Print version of the Parquet CLI tool")
28-
public class ShowVersionCommand implements Command {
29-
30-
private final Logger console;
29+
public class ShowVersionCommand extends BaseCommand {
3130

3231
public ShowVersionCommand(Logger console) {
33-
this.console = console;
32+
super(console);
3433
}
3534

3635
@Override

parquet-cli/src/test/java/org/apache/parquet/cli/commands/ShowVersionCommandTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import java.util.Queue;
2222
import org.apache.parquet.Version;
23-
import org.apache.parquet.cli.ShowVersionCommand;
2423
import org.junit.Assert;
2524
import org.junit.Test;
2625
import org.slf4j.Logger;

0 commit comments

Comments
 (0)