add more tests and fix some comments

Author: zhangfengcdt

parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnValueCollector.java

@@ -39,7 +39,6 @@ class ColumnValueCollector {
   private final ColumnDescriptor path;
   private final boolean statisticsEnabled;
   private final boolean sizeStatisticsEnabled;
-  private final boolean geospatialStatisticsEnabled;
   private BloomFilterWriter bloomFilterWriter;
   private BloomFilter bloomFilter;
   private Statistics<?> statistics;
@@ -50,7 +49,6 @@ class ColumnValueCollector {
     this.path = path;
     this.statisticsEnabled = props.getStatisticsEnabled(path);
     this.sizeStatisticsEnabled = props.getSizeStatisticsEnabled(path);
-    this.geospatialStatisticsEnabled = props.getStatisticsEnabled(path);
     resetPageStatistics();
     initBloomFilter(bloomFilterWriter, props);
   }
@@ -64,7 +62,7 @@ void resetPageStatistics() {
             path.getPrimitiveType(), path.getMaxRepetitionLevel(), path.getMaxDefinitionLevel())
         : SizeStatistics.noopBuilder(
             path.getPrimitiveType(), path.getMaxRepetitionLevel(), path.getMaxDefinitionLevel());
-    this.geospatialStatisticsBuilder = geospatialStatisticsEnabled
+    this.geospatialStatisticsBuilder = statisticsEnabled
         ? GeospatialStatistics.newBuilder(path.getPrimitiveType())
         : GeospatialStatistics.noopBuilder();
   }

…geometry/EdgeInterpolationAlgorithm.java …n/schema/EdgeInterpolationAlgorithm.javaparquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/EdgeInterpolationAlgorithm.java renamed to parquet-column/src/main/java/org/apache/parquet/column/schema/EdgeInterpolationAlgorithm.java parquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/EdgeInterpolationAlgorithm.java renamed to parquet-column/src/main/java/org/apache/parquet/column/schema/EdgeInterpolationAlgorithm.java

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.parquet.column.statistics.geometry;
+package org.apache.parquet.column.schema;
 
 /**
  * Edge interpolation algorithm for Geography logical type

parquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/BoundingBox.java

@@ -81,8 +81,7 @@ public double getMMax() {
 
   /**
    * Checks if the bounding box is valid.
-   * A bounding box is considered valid if none of the bounds are in their initial state
-   * (i.e., xMin = +Infinity, xMax = -Infinity, etc.) and none of the bounds contain NaN.
+   * A bounding box is considered valid if none of the bounds contain NaN.
    *
    * @return true if the bounding box is valid, false otherwise.
    */
@@ -92,26 +91,22 @@ public boolean isValid() {
 
   /**
    * Checks if the Z dimension of the bounding box is valid.
-   * The Z dimension is considered valid if zMin and zMax are not infinite
-   * and don't contain NaN values.
+   * The Z dimension is considered valid if none of the bounds contain NaN.
    *
    * @return true if the Z dimension is valid, false otherwise.
    */
   public boolean isZValid() {
-    return !(Double.isInfinite(zMin) || Double.isInfinite(zMax) ||
-        Double.isNaN(zMin) || Double.isNaN(zMax));
+    return !(Double.isNaN(zMin) || Double.isNaN(zMax));
   }
 
   /**
    * Checks if the M dimension of the bounding box is valid.
-   * The M dimension is considered valid if mMin and mMax are not infinite
-   * and don't contain NaN values.
+   * The M dimension is considered valid if none of the bounds contain NaN.
    *
    * @return true if the M dimension is valid, false otherwise.
    */
   public boolean isMValid() {
-    return !(Double.isInfinite(mMin) || Double.isInfinite(mMax) ||
-        Double.isNaN(mMin) || Double.isNaN(mMax));
+    return !(Double.isNaN(mMin) || Double.isNaN(mMax));
   }
 
   /**

parquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/GeospatialStatistics.java

@@ -19,6 +19,7 @@
 package org.apache.parquet.column.statistics.geometry;
 
 import org.apache.parquet.Preconditions;
+import org.apache.parquet.column.schema.EdgeInterpolationAlgorithm;
 import org.apache.parquet.io.api.Binary;
 import org.apache.parquet.schema.LogicalTypeAnnotation;
 import org.apache.parquet.schema.PrimitiveType;

parquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/GeospatialTypes.java

@@ -136,12 +136,8 @@ private int getGeometryTypeCode(Geometry geometry) {
     boolean hasZ = false;
     boolean hasM = false;
     for (Coordinate coordinate : coordinates) {
-      if (!Double.isNaN(coordinate.getZ())) {
-        hasZ = true;
-      }
-      if (!Double.isNaN(coordinate.getM())) {
-        hasM = true;
-      }
+      hasZ = !Double.isNaN(coordinate.getZ());
+      hasM = !Double.isNaN(coordinate.getM());
       if (hasZ && hasM) {
         break;
       }

parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java

@@ -41,7 +41,7 @@
 import java.util.Set;
 import java.util.function.Supplier;
 import org.apache.parquet.Preconditions;
-import org.apache.parquet.column.statistics.geometry.EdgeInterpolationAlgorithm;
+import org.apache.parquet.column.schema.EdgeInterpolationAlgorithm;
 
 public abstract class LogicalTypeAnnotation {
 

parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java

@@ -1323,7 +1323,7 @@ LogicalTypeAnnotation getLogicalTypeAnnotation(LogicalType type) {
         if (geography.getAlgorithm() != null) {
           return LogicalTypeAnnotation.geographyType(
               geography.getCrs(),
-              org.apache.parquet.column.statistics.geometry.EdgeInterpolationAlgorithm.valueOf(
+              org.apache.parquet.column.schema.EdgeInterpolationAlgorithm.valueOf(
                   String.valueOf(geography.getAlgorithm())));
         } else {
           return LogicalTypeAnnotation.geographyType(geography.getCrs(), null);