Skip to content

Commit 5aa608f

Browse files
yadavay-amznwgtmac
andauthored
Apply suggestions from code review
Co-authored-by: Gang Wu <ustcwg@gmail.com>
1 parent 3fcc6c8 commit 5aa608f

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

parquet-column/src/main/java/org/apache/parquet/column/values/fallback/FallbackValuesWriter.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class FallbackValuesWriter<I extends ValuesWriter & RequiresFallback, F e
3030

3131
public static <I extends ValuesWriter & RequiresFallback, F extends ValuesWriter> FallbackValuesWriter<I, F> of(
3232
I initialWriter, F fallBackWriter) {
33-
return new FallbackValuesWriter<>(initialWriter, fallBackWriter, 0);
33+
return new FallbackValuesWriter<>(initialWriter, fallBackWriter, /*checkAfterBytes=*/0);
3434
}
3535

3636
public static <I extends ValuesWriter & RequiresFallback, F extends ValuesWriter> FallbackValuesWriter<I, F> of(
@@ -50,9 +50,7 @@ public static <I extends ValuesWriter & RequiresFallback, F extends ValuesWriter
5050
private boolean fellBackAlready = false;
5151

5252
private boolean compressionChecked = false;
53-
5453
private final long checkAfterBytes;
55-
5654
/* Accumulates raw bytes across pages (only reset in resetDictionary) so the
5755
* threshold check works even when individual pages are smaller than checkAfterBytes. */
5856
private long cumulativeRawBytes = 0;
@@ -71,7 +69,7 @@ public static <I extends ValuesWriter & RequiresFallback, F extends ValuesWriter
7169
private long rawDataByteSize = 0;
7270

7371
public FallbackValuesWriter(I initialWriter, F fallBackWriter) {
74-
this(initialWriter, fallBackWriter, 0);
72+
this(initialWriter, fallBackWriter, /*checkAfterBytes=*/0);
7573
}
7674

7775
public FallbackValuesWriter(I initialWriter, F fallBackWriter, long checkAfterBytes) {

0 commit comments

Comments
 (0)