Skip to content

Commit 74e94ab

Browse files
committed
fix tests
1 parent 7955496 commit 74e94ab

3 files changed

Lines changed: 6 additions & 7 deletions

File tree

parquet-column/src/main/java/org/apache/parquet/column/statistics/geometry/GeospatialStatistics.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ public void update(Binary value) {
6262
Geometry geom = reader.read(value.getBytes());
6363
update(geom);
6464
} catch (ParseException e) {
65-
LOG.warn("Failed to parse WKB geometry, aborting statistics update", e);
66-
abort();
65+
LOG.warn("Failed to parse WKB geometry, omit it from stats", e);
6766
}
6867
}
6968

parquet-column/src/test/java/org/apache/parquet/column/statistics/geometry/TestGeospatialStatistics.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ public void testMergeNullGeospatialStatistics() {
9898
GeospatialStatistics validCopy = validStats.copy();
9999
validCopy.merge(nullStats);
100100
Assert.assertFalse(validCopy.isValid());
101-
Assert.assertNull(validCopy.getBoundingBox());
102-
Assert.assertNull(validCopy.getGeospatialTypes());
101+
Assert.assertNotNull(validCopy.getBoundingBox());
102+
Assert.assertNotNull(validCopy.getGeospatialTypes());
103103

104104
// Test merging null with valid
105105
nullStats = new GeospatialStatistics(null, null);
@@ -115,8 +115,8 @@ public void testMergeNullGeospatialStatistics() {
115115
// Test merging valid with null bounding box
116116
validCopy = validStats.copy();
117117
validCopy.merge(nullBboxStats);
118-
Assert.assertFalse(validCopy.isValid());
119-
Assert.assertNull(validCopy.getBoundingBox());
118+
Assert.assertTrue(validCopy.isValid());
119+
Assert.assertNotNull(validCopy.getBoundingBox());
120120
Assert.assertNotNull(validCopy.getGeospatialTypes());
121121
}
122122

parquet-hadoop/src/test/java/org/apache/parquet/statistics/TestGeometryTypeRoundTrip.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public void testBasicReadWriteGeographyValue() throws Exception {
165165
Assert.assertNotNull(columnIndex);
166166

167167
GeospatialStatistics geospatialStatistics = columnChunkMetaData.getGeospatialStatistics();
168-
Assert.assertNotNull(geospatialStatistics);
168+
Assert.assertNull(geospatialStatistics);
169169
}
170170
}
171171

0 commit comments

Comments
 (0)