Remove Parquet-Pig (#3377)

* [parquet-thrift] remove pig usage

* final pig cleanups

* Put mention of Pig back in README

* MINOR: Exclude removed parquet-thrift Pig APIs from japicmp

Author: dossett

.github/ISSUE_TEMPLATE/feature_request.yaml

@@ -40,7 +40,6 @@ body:
         - Build
         - Arrow
         - Avro
-        - Pig
         - Protobuf
         - Thrift
         - CLI

parquet-thrift/pom.xml

@@ -70,7 +70,7 @@
       <scope>provided</scope>
     </dependency>
     <!-- Guava is a dependency of hadoop-common, but scoped to compile. We need to
-         explicity declare it as a test dependency. -->
+         explicitly declare it as a test dependency. -->
     <dependency>
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
@@ -95,18 +95,6 @@
         </exclusion>
       </exclusions>
     </dependency>
-    <dependency>
-      <groupId>com.twitter.elephantbird</groupId>
-      <artifactId>elephant-bird-pig</artifactId>
-      <version>${elephant-bird.version}</version>
-      <exclusions>
-        <!-- hadoop-lzo is not required for parquet build/tests and there are issues downloading it -->
-        <exclusion>
-          <groupId>com.hadoop.gplcompression</groupId>
-          <artifactId>hadoop-lzo</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>
     <dependency>
       <groupId>org.apache.parquet</groupId>
       <artifactId>parquet-jackson</artifactId>
@@ -130,18 +118,6 @@
       <type>test-jar</type>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.parquet</groupId>
-      <artifactId>parquet-pig</artifactId>
-      <version>1.15.2</version>
-    </dependency>
-    <dependency>
-      <groupId>org.apache.pig</groupId>
-      <artifactId>pig</artifactId>
-      <version>${pig.version}</version>
-      <classifier>${pig.classifier}</classifier>
-      <scope>provided</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.thrift</groupId>
       <artifactId>libthrift</artifactId>

parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/AbstractThriftWriteSupport.java

@@ -15,7 +15,6 @@
  */
 package org.apache.parquet.hadoop.thrift;
 
-import com.twitter.elephantbird.pig.util.ThriftToPig;
 import java.util.Map;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.parquet.conf.HadoopParquetConfiguration;
@@ -25,13 +24,11 @@
 import org.apache.parquet.io.ColumnIOFactory;
 import org.apache.parquet.io.MessageColumnIO;
 import org.apache.parquet.io.api.RecordConsumer;
-import org.apache.parquet.pig.PigMetaData;
 import org.apache.parquet.schema.MessageType;
 import org.apache.parquet.thrift.ParquetWriteProtocol;
 import org.apache.parquet.thrift.ThriftMetaData;
 import org.apache.parquet.thrift.ThriftSchemaConverter;
 import org.apache.parquet.thrift.struct.ThriftType.StructType;
-import org.apache.thrift.TBase;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -99,26 +96,10 @@ protected void init(Class<T> thriftClass) {
 
     final Map<String, String> extraMetaData =
         new ThriftMetaData(thriftClass.getName(), thriftStruct).toExtraMetaData();
-    // adding the Pig schema as it would have been mapped from thrift
-    // TODO: make this work for non-tbase types
-    if (isPigLoaded() && TBase.class.isAssignableFrom(thriftClass)) {
-      new PigMetaData(new ThriftToPig((Class<? extends TBase<?, ?>>) thriftClass).toSchema())
-          .addToMetaData(extraMetaData);
-    }
 
     this.writeContext = new WriteContext(schema, extraMetaData);
   }
 
-  protected boolean isPigLoaded() {
-    try {
-      Class.forName("org.apache.pig.impl.logicalLayer.schema.Schema");
-      return true;
-    } catch (ClassNotFoundException e) {
-      LOG.info("Pig is not loaded, pig metadata will not be written");
-      return false;
-    }
-  }
-
   @Override
   public WriteContext init(Configuration configuration) {
     return init(new HadoopParquetConfiguration(configuration));

parquet-thrift/src/main/java/org/apache/parquet/thrift/pig/ParquetThriftStorer.java

@@ -142,6 +142,7 @@ default R visit(UUIDType uuidType, S state) {
   /**
    * @deprecated will be removed in 2.0.0; use StateVisitor instead.
    */
+  @Deprecated
   public interface TypeVisitor {
 
     void visit(MapType mapType);