update

Author: ArnavBalyan

parquet-common/src/main/java/org/apache/parquet/storage/impl/NioStorageProvider.java

@@ -22,6 +22,7 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.nio.file.AtomicMoveNotSupportedException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;

parquet-common/src/test/java/org/apache/parquet/storage/TestStorage.java

@@ -51,18 +51,14 @@ public void testRelativePathReturnsNioProvider() {
         provider instanceof org.apache.parquet.storage.impl.NioStorageProvider);
   }
 
-  @Test
-  public void testHdfsSchemeReturnsHadoopProvider() {
-    StorageProvider provider = Storage.select(URI.create("hdfs://namenode:8020/test.parquet"));
-    assertNotNull("Should return a provider", provider);
+  @Test(expected = IllegalStateException.class)
+  public void testHdfsSchemeThrowsExceptionWhenHadoopNotAvailable() {
+    Storage.select(URI.create("hdfs://namenode:8020/test.parquet"));
   }
 
-  @Test
-  public void testUnknownSchemeReturnsNioProvider() {
-    StorageProvider provider = Storage.select(URI.create("s3://bucket/test.parquet"));
-    assertTrue(
-        "unknown scheme should return NioStorageProvider",
-        provider instanceof org.apache.parquet.storage.impl.NioStorageProvider);
+  @Test(expected = IllegalStateException.class)
+  public void testUnknownSchemeThrowsExceptionWhenHadoopNotAvailable() {
+    Storage.select(URI.create("s3://bucket/test.parquet"));
   }
 
   @Test
@@ -71,4 +67,24 @@ public void testNioProviderBasicOperations() throws IOException {
 
     assertTrue(provider instanceof org.apache.parquet.storage.impl.NioStorageProvider);
   }
+
+  @Test
+  public void testProviderSelectionLogic() {
+    StorageProvider fileProvider = Storage.select(URI.create("file:///tmp/test.parquet"));
+    assertTrue(
+        "file:// should always return NIO provider",
+        fileProvider instanceof org.apache.parquet.storage.impl.NioStorageProvider);
+
+    try {
+      Storage.select(URI.create("hdfs://namenode:8020/test.parquet"));
+      fail("Should throw IllegalStateException for hdfs:// when Hadoop not available");
+    } catch (IllegalStateException e) {
+    }
+
+    try {
+      Storage.select(URI.create("s3://bucket/test.parquet"));
+      fail("Should throw IllegalStateException for s3:// when Hadoop not available");
+    } catch (IllegalStateException e) {
+    }
+  }
 }