Skip to content

Commit db9231c

Browse files
committed
BINARY_AS_INT_96_COMPARATOR -> BINARY_AS_INT96_TIMESTAMP_COMPARATOR
1 parent 43028d7 commit db9231c

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ public String toString() {
209209
/*
210210
* This comparator is for comparing two timestamps represented as int96 binary.
211211
*/
212-
static final PrimitiveComparator<Binary> BINARY_AS_INT_96_COMPARATOR = new BinaryComparator() {
212+
static final PrimitiveComparator<Binary> BINARY_AS_INT96_TIMESTAMP_COMPARATOR = new BinaryComparator() {
213213
@Override
214214
int compareBinary(Binary b1, Binary b2) {
215215
ByteBuffer bb1 = b1.toByteBuffer();
@@ -227,7 +227,7 @@ int compareBinary(Binary b1, Binary b2) {
227227

228228
@Override
229229
public String toString() {
230-
return "BINARY_AS_INT_96_COMPARATOR";
230+
return "BINARY_AS_INT96_TIMESTAMP_COMPARATOR";
231231
}
232232
};
233233

parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public <T, E extends Exception> T convert(PrimitiveTypeNameConverter<T, E> conve
362362

363363
@Override
364364
PrimitiveComparator<?> comparator(LogicalTypeAnnotation logicalType) {
365-
return PrimitiveComparator.BINARY_AS_INT_96_COMPARATOR;
365+
return PrimitiveComparator.BINARY_AS_INT96_TIMESTAMP_COMPARATOR;
366366
}
367367
},
368368
FIXED_LEN_BYTE_ARRAY("getBinary", Binary.class) {

parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveComparator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package org.apache.parquet.schema;
2020

2121
import static org.apache.parquet.schema.PrimitiveComparator.BINARY_AS_FLOAT16_COMPARATOR;
22-
import static org.apache.parquet.schema.PrimitiveComparator.BINARY_AS_INT_96_COMPARATOR;
22+
import static org.apache.parquet.schema.PrimitiveComparator.BINARY_AS_INT96_TIMESTAMP_COMPARATOR;
2323
import static org.apache.parquet.schema.PrimitiveComparator.BINARY_AS_SIGNED_INTEGER_COMPARATOR;
2424
import static org.apache.parquet.schema.PrimitiveComparator.BOOLEAN_COMPARATOR;
2525
import static org.apache.parquet.schema.PrimitiveComparator.DOUBLE_COMPARATOR;
@@ -302,7 +302,7 @@ public void testInt96Comparator() {
302302
for (int j = 0; j < valuesInAscendingOrder.length; ++j) {
303303
Binary bi = valuesInAscendingOrder[i];
304304
Binary bj = valuesInAscendingOrder[j];
305-
assertEquals(Integer.compare(i, j), BINARY_AS_INT_96_COMPARATOR.compare(bi, bj));
305+
assertEquals(Integer.compare(i, j), BINARY_AS_INT96_TIMESTAMP_COMPARATOR.compare(bi, bj));
306306
}
307307
}
308308
}

0 commit comments

Comments
 (0)