Add slicing to fix bug with the comparator

Author: rahulketch

parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveComparator.java

@@ -215,8 +215,8 @@ public String toString() {
   static final PrimitiveComparator<Binary> BINARY_AS_INT96_TIMESTAMP_COMPARATOR = new BinaryComparator() {
     @Override
     int compareBinary(Binary b1, Binary b2) {
-      ByteBuffer bb1 = b1.toByteBuffer();
-      ByteBuffer bb2 = b2.toByteBuffer();
+      ByteBuffer bb1 = b1.toByteBuffer().slice();
+      ByteBuffer bb2 = b2.toByteBuffer().slice();
       bb1.order(java.nio.ByteOrder.LITTLE_ENDIAN);
       bb2.order(java.nio.ByteOrder.LITTLE_ENDIAN);
       int jd1 = bb1.getInt(8);

parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveComparator.java

@@ -287,22 +287,47 @@ private Binary timestampToInt96(String timestamp) {
   @Test
   public void testInt96Comparator() {
     Binary[] valuesInAscendingOrder = {
-      timestampToInt96("2020-01-01T00:00:00.000"),
-      timestampToInt96("2020-02-29T23:59:59.999"),
-      timestampToInt96("2020-12-31T23:59:59.999"),
-      timestampToInt96("2021-01-01T00:00:00.000"),
-      timestampToInt96("2023-06-15T12:30:45.500"),
-      timestampToInt96("2024-02-29T15:45:30.750"),
-      timestampToInt96("2024-12-25T07:00:00.000"),
-      timestampToInt96("2025-01-01T00:00:00.000"),
-      timestampToInt96("2025-07-04T20:00:00.000"),
-      timestampToInt96("2025-12-31T23:59:59.999")
+            timestampToInt96("2020-01-01T00:00:00.000"),
+            timestampToInt96("2020-01-01T10:00:00.000"),
+            timestampToInt96("2020-02-29T23:59:59.999"),
+            timestampToInt96("2020-12-31T23:59:59.999"),
+            timestampToInt96("2021-01-01T00:00:00.000"),
+            timestampToInt96("2023-06-15T12:30:45.500"),
+            timestampToInt96("2024-02-29T15:45:30.750"),
+            timestampToInt96("2024-12-25T07:00:00.000"),
+            timestampToInt96("2025-01-01T00:00:00.000"),
+            timestampToInt96("2025-07-04T20:00:00.000"),
+            timestampToInt96("2025-07-04T20:50:00.000"),
+            timestampToInt96("2025-12-31T23:59:59.999")
     };
+    
+    java.util.function.Function<Binary, Binary>[] perturb = new java.util.function.Function[] {
+        (java.util.function.Function<Binary, Binary>) b -> b,
+        (java.util.function.Function<Binary, Binary>) b -> Binary.fromReusedByteArray(b.getBytes()),
+        (java.util.function.Function<Binary, Binary>) b -> Binary.fromConstantByteArray(b.getBytes()),
+        (java.util.function.Function<Binary, Binary>) b -> {
+          byte[] originalBytes = b.getBytes();
+          byte[] paddedBuffer = new byte[originalBytes.length + 20];
+          int offset = 10;
+          for (int i = 0; i < paddedBuffer.length; i++) {
+            paddedBuffer[i] = (byte) (0xAA + (i % 5));
+          }
+          System.arraycopy(originalBytes, 0, paddedBuffer, offset, originalBytes.length);
+          return Binary.fromReusedByteArray(paddedBuffer, offset, originalBytes.length);
+        }
+    };
+    
     for (int i = 0; i < valuesInAscendingOrder.length; ++i) {
       for (int j = 0; j < valuesInAscendingOrder.length; ++j) {
         Binary bi = valuesInAscendingOrder[i];
         Binary bj = valuesInAscendingOrder[j];
-        assertEquals(Integer.compare(i, j), BINARY_AS_INT96_TIMESTAMP_COMPARATOR.compare(bi, bj));
+        for (java.util.function.Function<Binary, Binary> fi : perturb) {
+          for (java.util.function.Function<Binary, Binary> fj : perturb) {
+            Binary perturbedBi = fi.apply(bi);
+            Binary perturbedBj = fj.apply(bj);
+            assertEquals(Integer.compare(i, j), BINARY_AS_INT96_TIMESTAMP_COMPARATOR.compare(perturbedBi, perturbedBj));
+          }
+        }
       }
     }
   }