PDFBOX-6207: simplify getting string

Maruan Sahyoun · Maruan Sahyoun · commit 2679d1d53acc · 2026-05-28T08:46:48.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934717 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
@@ -253,12 +253,12 @@ public List<String> getExportValues()
         
         if (value instanceof COSString)
         {
-            COSString stringValue = (COSString) value;
-            if (stringValue.getString().isEmpty())
+            String stringValue = ((COSString) value).getString();
+            if (stringValue.isEmpty())
             {
                 return Collections.emptyList();
             }
-            return Collections.singletonList(((COSString) value).getString());
+            return Collections.singletonList(stringValue);
         }
         else if (value instanceof COSArray)
         {

Original file line number	Diff line number	Diff line change
`@@ -253,12 +253,12 @@ public List<String> getExportValues()`
`253`	`253`
`254`	`254`	`if (value instanceof COSString)`
`255`	`255`	`{`
`256`		`- COSString stringValue = (COSString) value;`
`257`		`- if (stringValue.getString().isEmpty())`
	`256`	`+ String stringValue = ((COSString) value).getString();`
	`257`	`+ if (stringValue.isEmpty())`
`258`	`258`	`{`
`259`	`259`	`return Collections.emptyList();`
`260`	`260`	`}`
`261`		`- return Collections.singletonList(((COSString) value).getString());`
	`261`	`+ return Collections.singletonList(stringValue);`
`262`	`262`	`}`
`263`	`263`	`else if (value instanceof COSArray)`
`264`	`264`	`{`