PDFBOX-5660: optimize, as suggested by Valery Bokov; improve javadoc; closes #264

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928757 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/action/PDActionEmbeddedGoTo.java

@@ -124,13 +124,14 @@ public void setFile(PDFileSpecification fs)
      * This will specify whether to open the destination document in a new window, in the same
      * window, or behave in accordance with the current user preference.
      *
-     * @return A flag specifying how to open the destination document.
+     * @return A flag specifying how to open the destination document, never null.
      */
     public OpenMode getOpenInNewWindow()
     {
-        if (getCOSObject().getDictionaryObject(COSName.NEW_WINDOW) instanceof COSBoolean)
+        COSBase dictionaryObject = getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+        if (dictionaryObject instanceof COSBoolean)
         {
-            COSBoolean b = (COSBoolean) getCOSObject().getDictionaryObject(COSName.NEW_WINDOW);
+            COSBoolean b = (COSBoolean) dictionaryObject;
             return b.getValue() ? OpenMode.NEW_WINDOW : OpenMode.SAME_WINDOW;
         }
         return OpenMode.USER_PREFERENCE;