PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #390

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1931139 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/shading/PDShadingType5.java

@@ -158,28 +158,32 @@ private List<ShadedTriangle> createShadedTriangleList(int rowNum, int numPerRow,
     {
         Point2D[] ps = new Point2D[3]; // array will be shallow-cloned in ShadedTriangle constructor
         float[][] cs = new float[3][];
-        List<ShadedTriangle> list = new ArrayList<>();
+        List<ShadedTriangle> list = new ArrayList<>((rowNum - 1) * (numPerRow - 1));
         for (int i = 0; i < rowNum - 1; i++)
         {
             for (int j = 0; j < numPerRow - 1; j++)
             {
-                ps[0] = latticeArray[i][j].point;
-                ps[1] = latticeArray[i][j + 1].point;
-                ps[2] = latticeArray[i + 1][j].point;
-
-                cs[0] = latticeArray[i][j].color;
-                cs[1] = latticeArray[i][j + 1].color;
-                cs[2] = latticeArray[i + 1][j].color;
+                Vertex vertex1 = latticeArray[i][j];
+                Vertex vertex2 = latticeArray[i][j + 1];
+                Vertex vertex3 = latticeArray[i + 1][j];
+                Vertex vertex4 = latticeArray[i + 1][j + 1];
+                ps[0] = vertex1.point;
+                ps[1] = vertex2.point;
+                ps[2] = vertex3.point;
+
+                cs[0] = vertex1.color;
+                cs[1] = vertex2.color;
+                cs[2] = vertex3.color;
 
                 list.add(new ShadedTriangle(ps, cs));
 
-                ps[0] = latticeArray[i][j + 1].point;
-                ps[1] = latticeArray[i + 1][j].point;
-                ps[2] = latticeArray[i + 1][j + 1].point;
+                ps[0] = vertex2.point;
+                ps[1] = vertex3.point;
+                ps[2] = vertex4.point;
 
-                cs[0] = latticeArray[i][j + 1].color;
-                cs[1] = latticeArray[i + 1][j].color;
-                cs[2] = latticeArray[i + 1][j + 1].color;
+                cs[0] = vertex2.color;
+                cs[1] = vertex3.color;
+                cs[2] = vertex4.color;
 
                 list.add(new ShadedTriangle(ps, cs));
             }