PDFBOX-5660: refactor, avoid leaking this in constructor

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934038 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

debugger/src/main/java/org/apache/pdfbox/debugger/streampane/StreamTextView.java

@@ -65,6 +65,7 @@ private void initUI(StyledDocument document)
         textPane.addMouseMotionListener(this);
         textPane.setFont(new Font("monospaced", Font.PLAIN, 13));
         searcher = new Searcher(textPane);
+        searcher.init();
 
         JScrollPane scrollPane = new JScrollPane(textPane);
 

debugger/src/main/java/org/apache/pdfbox/debugger/ui/textsearcher/Searcher.java

@@ -52,7 +52,7 @@ public class Searcher implements DocumentListener, ChangeListener, ComponentList
     private static final Highlighter.HighlightPainter SELECTION_PAINTER =
             new DefaultHighlighter.DefaultHighlightPainter(new Color(109, 216, 26));
     private final SearchEngine searchEngine;
-    private final SearchPanel searchPanel;
+    private SearchPanel searchPanel;
     private final JTextComponent textComponent;
     private int totalMatch = 0;
     private int currentMatch = -1;
@@ -97,13 +97,21 @@ public void actionPerformed(ActionEvent actionEvent)
     public Searcher(JTextComponent textComponent)
     {
         this.textComponent = textComponent;
-        searchPanel = new SearchPanel(this, this, this, nextAction, previousAction);
         searchEngine = new SearchEngine(textComponent, PAINTER);
 
         nextAction.setEnabled(false);
         previousAction.setEnabled(false);
     }
 
+    /**
+     * Initialization, to be called immediately after construction.
+     */
+    public void init()
+    {
+        searchPanel = new SearchPanel(this, this, this, nextAction, previousAction);
+    }
+
+
     public JPanel getSearchPanel()
     {
         return searchPanel.getPanel();