PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #453

lehmi · lehmi · commit 6b9b255eb471 · 2026-05-23T11:04:29.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934530 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/compress/COSWriterCompressionPool.java b/pdfbox/src/main/java/org/apache/pdfbox/pdfwriter/compress/COSWriterCompressionPool.java
@@ -117,7 +117,7 @@ private COSBase addObjectToPool(COSObjectKey key, COSBase base)
         {
             return current;
         }
-        if (current != null && key != null && objectPool.contains(key))
+        if (key != null && objectPool.contains(key))
         {
             COSBase cosObject = objectPool.getObject(key);
             // check if the key belongs to the same object

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ private COSBase addObjectToPool(COSObjectKey key, COSBase base)`
`117`	`117`	`{`
`118`	`118`	`return current;`
`119`	`119`	`}`
`120`		`- if (current != null && key != null && objectPool.contains(key))`
	`120`	`+ if (key != null && objectPool.contains(key))`
`121`	`121`	`{`
`122`	`122`	`COSBase cosObject = objectPool.getObject(key);`
`123`	`123`	`// check if the key belongs to the same object`