Skip to content

Commit 74c3e5a

Browse files
committed
PDFBOX-6193: avoid AIOOBE due to a negative hash based on a proposal by Stefan Ziegler
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934290 13f79535-47bb-0310-9956-ffa450edef68
1 parent a747a9f commit 74c3e5a

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/TrueTypeEmbedder.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,8 @@ protected abstract void buildSubset(InputStream ttfSubset, String tag,
364364
*/
365365
public String getTag(Map<Integer, Integer> gidToCid)
366366
{
367-
// deterministic
368-
long num = gidToCid.hashCode();
369-
367+
// hash might be negative due to an overflow if the map contains lots of values
368+
long num = Math.abs(gidToCid.hashCode());
370369
// base25 encode
371370
StringBuilder sb = new StringBuilder();
372371
do

0 commit comments

Comments
 (0)