PDFBOX-5660: create RandomAccessOutputStream within try clause

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1932932 13f79535-47bb-0310-9956-ffa450edef68

Author: Maruan Sahyoun

pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java

@@ -230,11 +230,12 @@ public OutputStream createOutputStream(COSBase filters) throws IOException
             randomAccess.clear();
         else
             randomAccess = getStreamCache().createBuffer();
-        OutputStream randomOut = new RandomAccessOutputStream(randomAccess);
-        boolean success = false;
+        OutputStream randomOut = null;
 
         try
         {
+            randomOut = new RandomAccessOutputStream(randomAccess);
+
             OutputStream cosOut = new COSOutputStream(getFilterList(), this, randomOut,
                     getStreamCache());
             isWriting = true;
@@ -254,12 +255,12 @@ public void close() throws IOException
                     isWriting = false;
                 }
             };
-            success = true;
+            randomOut = null; // ownership transferred to result, so don't close it in the finally block
             return result;
         }
         finally
         {
-            if (!success)
+            if (randomOut != null)
             {
                 // clean up partially written data
                 randomOut.close();