Skip to content

Commit 825c7d8

Browse files
committed
PDFBOX-5660: refactor, avoid leaking this in constructor
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1934045 13f79535-47bb-0310-9956-ffa450edef68
1 parent 77be3ec commit 825c7d8

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1064,6 +1064,7 @@ private void showPage(Object selectedNode)
10641064
if (COSName.PAGE.equals(typeItem))
10651065
{
10661066
PagePane pagePane = new PagePane(document, page, statusBar.getStatusLabel());
1067+
pagePane.init();
10671068
replaceRightComponent(new JScrollPane(pagePane.getPanel()));
10681069
}
10691070
}

debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,13 @@ public PagePane(PDDocument document, COSDictionary pageDict, JLabel statuslabel)
120120
pageIndex = document.getPages().indexOf(page);
121121
this.document = document;
122122
this.statuslabel = statuslabel;
123+
}
124+
125+
/**
126+
* Initialization, to be called immediately after construction.
127+
*/
128+
public void init()
129+
{
123130
initUI();
124131
initRectMap();
125132
}

0 commit comments

Comments
 (0)