PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #254

THausherr · THausherr · commit c475bea360f0 · 2025-09-15T12:24:24.000Z
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1928492 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontMapperImpl.java b/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/font/FontMapperImpl.java
@@ -468,10 +468,11 @@ private FontBoxFont findFont(FontFormat format, String postScriptName)
      */
     private FontInfo getFont(FontFormat format, String postScriptName)
     {
+        int index = postScriptName.indexOf('+');
         // strip subset tag (happens when we substitute a corrupt embedded font, see PDFBOX-2642)
-        if (postScriptName.contains("+"))
+        if (index > -1)
         {
-            postScriptName = postScriptName.substring(postScriptName.indexOf('+') + 1);
+            postScriptName = postScriptName.substring(index + 1);
         }
         
         // look up the PostScript name

Original file line number	Diff line number	Diff line change
`@@ -468,10 +468,11 @@ private FontBoxFont findFont(FontFormat format, String postScriptName)`
`468`	`468`	`*/`
`469`	`469`	`private FontInfo getFont(FontFormat format, String postScriptName)`
`470`	`470`	`{`
	`471`	`+ int index = postScriptName.indexOf('+');`
`471`	`472`	`// strip subset tag (happens when we substitute a corrupt embedded font, see PDFBOX-2642)`
`472`		`- if (postScriptName.contains("+"))`
	`473`	`+ if (index > -1)`
`473`	`474`	`{`
`474`		`- postScriptName = postScriptName.substring(postScriptName.indexOf('+') + 1);`
	`475`	`+ postScriptName = postScriptName.substring(index + 1);`
`475`	`476`	`}`
`476`	`477`
`477`	`478`	`// look up the PostScript name`