PDFBOX-5660: replace runtime throw; remove unintended quotes

git-svn-id: https://svn.apache.org/repos/asf/pdfbox/trunk@1932636 13f79535-47bb-0310-9956-ffa450edef68

Author: THausherr

debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java

@@ -248,7 +248,7 @@ public PDFDebugger(String initialViewMode)
         }
         else
         {
-            new ErrorDialog(new IllegalArgumentException("Unknown view mode: " + "initialViewMode")).setVisible(true);
+            new ErrorDialog(new IllegalArgumentException("Unknown view mode: " + initialViewMode)).setVisible(true);
         }
     }
 
@@ -362,9 +362,9 @@ private void loadConfiguration()
                     configuration.load(is);
                 }
             }
-            catch(IOException e)
+            catch (IOException ex)
             {
-                throw new RuntimeException(e);
+                new ErrorDialog(ex).setVisible(true);
             }
         }
     }
@@ -516,9 +516,9 @@ protected void initGlobalEventHandlers()
                 osxQuit.setAccessible(true);
                 OSXAdapter.setQuitHandler(this, osxQuit);
             }
-            catch (NoSuchMethodException e)
+            catch (NoSuchMethodException ex)
             {
-                throw new RuntimeException(e);
+                new ErrorDialog(ex).setVisible(true);
             }
         }
     }
@@ -546,9 +546,9 @@ private JMenu createFileMenu()
             {
                 readPDFurl(urlString, "");
             }
-            catch (IOException | URISyntaxException e)
+            catch (IOException | URISyntaxException ex)
             {
-                throw new RuntimeException(e);
+                new ErrorDialog(ex).setVisible(true);
             }
         });
         fileMenu.add(openUrlMenuItem);
@@ -1255,9 +1255,9 @@ private String convertToString( Object selectedNode )
                     return new String(in.readAllBytes());
                 }
             }
-            catch( IOException e )
+            catch (IOException ex)
             {
-                throw new RuntimeException(e);
+                new ErrorDialog(ex).setVisible(true);
             }
         }
         if (selectedNode instanceof COSDictionary)
@@ -1586,9 +1586,9 @@ public void actionPerformed(ActionEvent actionEvent)
                 {
                     readPDFFile(filePath, "");
                 }
-                catch (Exception e)
+                catch (Exception ex)
                 {
-                    throw new RuntimeException(e);
+                    new ErrorDialog(ex).setVisible(true);
                 }
             }
         };

debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java

@@ -579,10 +579,10 @@ protected void done()
                 label.setIcon(new HighResolutionImageIcon(image, label.getWidth(), label.getHeight()));
                 label.setText(null);
             }
-            catch (InterruptedException | ExecutionException e)
+            catch (InterruptedException | ExecutionException ex)
             {
-                label.setText(e.getMessage());
-                throw new RuntimeException(e);
+                label.setText(ex.getMessage());
+                new ErrorDialog(ex).setVisible(true);
             }
         }
     }