avoid pekko Java API Option class#709
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Java API from using Pekko's Option type to Java's standard Optional type, deprecating the old methods in favor of more idiomatic Java code.
- Deprecates existing
createmethods that useOption<String>parameters - Adds new
createmethods that useOptional<String>parameters - Updates method calls throughout the codebase to use
Optionalinstead ofOption
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HttpChallenge.java | Adds new Optional-based factory methods, deprecates existing Option-based methods, and updates convenience methods to use Optional |
| SecurityDirectivesExamplesTest.java | Updates test code to use Optional instead of Option for HttpChallenge creation |
| @@ -32,7 +32,6 @@ | |||
| import java.util.concurrent.CompletionStage; | |||
| import java.util.function.Function; | |||
| import java.util.Optional; | |||
There was a problem hiding this comment.
The import for java.util.Optional was already present at line 34 (based on the diff context). This suggests there might be duplicate imports, which should be cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java API class now deprecated in favour of java Optional.
see #708