no need to convert to ActorMaterializer#712
Merged
Merged
Conversation
pjfanning
requested review from
Copilot and
mdedetrich
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated ActorMaterializerHelper usage throughout the Pekko HTTP codebase in preparation for Pekko 2.0.0. The changes replace calls to ActorMaterializerHelper.downcast(materializer).system with direct access to materializer.system.
- Removes import statements for the deprecated
ActorMaterializerHelper - Updates materializer system access patterns to use the direct API
- Affects server directives, unmarshalling, routing, and HTTP server blueprint components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MultipartUnmarshallers.scala | Removes ActorMaterializerHelper import and updates ParserSettings initialization |
| BasicDirectives.scala | Updates extractActorSystem directive to use direct materializer.system access |
| RouteResult.scala | Removes ActorMaterializerHelper usage in deprecated route-to-flow conversion |
| Route.scala | Updates ParserSettings creation to use direct materializer.system access |
| HttpServerBluePrint.scala | Updates parsing error handler and timeout settings to use direct materializer access |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActorMaterializerHelper is deprecated and due for removal in pekko 2.0.0. Relates to #714