Migrate integration test AWS CloudFormation/AutoScaling from SDK v1 to v2#725
Draft
pjfanning wants to merge 3 commits into
Draft
Migrate integration test AWS CloudFormation/AutoScaling from SDK v1 to v2#725pjfanning wants to merge 3 commits into
pjfanning wants to merge 3 commits into
Conversation
…re.amazon.awssdk v2 Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> Agent-Logs-Url: https://github.com/pjfanning/incubator-pekko-management/sessions/541c8e96-562c-4514-87a1-0fb2c59589ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aws-api-ec2integration test used legacycom.amazonaws(SDK v1) for CloudFormation and AutoScaling, while the rest of the project already adoptssoftware.amazon.awssdk(SDK v2).Changes
project/Dependencies.scala: ExtractedawsSdkV2Version = "2.42.19"constant; updated existingecsv2 dependency to reference itintegration-test/aws-api-ec2/build.sbt: Replacedcom.amazonaws:aws-java-sdk-cloudformationandcom.amazonaws:aws-java-sdk-autoscalingwith theirsoftware.amazon.awssdkequivalents (withapache-clientexcluded, consistent with the ECS dependency)IntegrationTest.scala: Migrated CloudFormation API from v1 mutable-builder style to v2 immutable-builder pattern; updated response types and accessorsBefore:
After: