build: remove Scala 2-only compiler options from Scala 3 projects#169
Merged
Conversation
Motivation: All sample projects use Scala 3.3.7 but several still include Scala 2 compiler options (-Xlog-reflective-calls, -Xlint, -Ywarn-unused:imports) that produce "bad option" warnings or are silently ignored. Modification: Remove -Xlog-reflective-calls, -Xlint (without arguments), and -Ywarn-unused:imports from scalacOptions in 10 sample build.sbt files. Keep -deprecation, -feature, -unchecked which are valid in both Scala 2 and 3. Result: Clean compilation without "bad option" warnings in all affected samples.
LuuOW
reviewed
Jun 17, 2026
LuuOW
left a comment
LuuOW
left a comment
There was a problem hiding this comment.
Technical audit: code patterns and functional logic verified for system integrity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Xlog-reflective-calls,-Xlint(without arguments), and-Ywarn-unused:importsfrom 10 samplebuild.sbtfiles-deprecation,-feature,-uncheckedwhich are valid in both Scala 2 and 3Test plan
sbt compileinpekko-sample-cluster-scalaproduces no "bad option" warningsAffected samples: