Skip to content

Commit 2dc4573

Browse files
committed
Fix CI linter and quickstart build
How to reproduce:\n- Run the Pinot Linter Test Set job and observe the license check fail on PredicateUtils.java.\n- Run the quickstart build path without the sqlparser profile, for example via .github/workflows/scripts/.pinot_quickstart.sh, and observe pinot-common fail because SqlParserImpl is not generated after clean.\n\nWhat changed:\n- Restore the expected ASF header formatting in PredicateUtils.java so license:check passes again.\n- Enable the sqlparser profile in the quickstart build script so clean install regenerates the Calcite parser sources in CI.
1 parent 28f894d commit 2dc4573

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/scripts/.pinot_quickstart.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ echo "Building Pinot to JAVA 11 source code Using JDK ${JAVA_VER}"
8080
PASS=0
8181
for i in $(seq 1 2)
8282
do
83-
mvn clean install -B -ntp -T1C -DskipTests -Pbin-dist -Dmaven.javadoc.skip=true -Djdk.version=11
83+
mvn clean install -B -ntp -T1C -DskipTests -Pbin-dist,sqlparser -Dmaven.javadoc.skip=true -Djdk.version=11
8484
if [ $? -eq 0 ]; then
8585
PASS=1
8686
break;

pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* "License"); you may not use this file except in compliance
88
* with the License. You may obtain a copy of the License at
99
*
10-
* http://www.apache.org/licenses/LICENSE-2.0
10+
* http://www.apache.org/licenses/LICENSE-2.0
1111
*
1212
* Unless required by applicable law or agreed to in writing,
1313
* software distributed under the License is distributed on an

0 commit comments

Comments
 (0)