Change default Scala version to 2.13 (#18100)

* Change default Scala version to 2.13

* Fix Scala 2.13 array equality in spark common tests

Author: xiangfu0

LICENSE-binary

@@ -223,7 +223,7 @@ com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:2.21.1
 com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:2.21.1
 com.fasterxml.jackson.module:jackson-module-jaxb-annotations:2.21.1
 com.fasterxml.jackson.module:jackson-module-parameter-names:2.21.1
-com.fasterxml.jackson.module:jackson-module-scala_2.12:2.21.1
+com.fasterxml.jackson.module:jackson-module-scala_2.13:2.21.1
 com.fasterxml.woodstox:woodstox-core:7.1.1
 com.github.ben-manes.caffeine:caffeine:2.9.3
 com.github.erosb:everit-json-schema:1.14.6
@@ -279,7 +279,7 @@ com.squareup.wire:wire-schema-jvm:5.1.0
 com.squareup:javapoet:1.13.0
 com.squareup:kotlinpoet-jvm:1.18.1
 com.tdunning:t-digest:3.2
-com.typesafe.scala-logging:scala-logging_2.12:3.9.5
+com.typesafe.scala-logging:scala-logging_2.13:3.9.5
 com.uber:h3:4.4.0
 com.yammer.metrics:metrics-core:2.2.0
 com.yscope.clp:clp-ffi:0.4.7
@@ -459,7 +459,7 @@ org.apache.kafka:kafka-storage-api:3.9.2
 org.apache.kafka:kafka-storage:3.9.2
 org.apache.kafka:kafka-tools-api:3.9.2
 org.apache.kafka:kafka-transaction-coordinator:3.9.2
-org.apache.kafka:kafka_2.12:3.9.2
+org.apache.kafka:kafka_2.13:3.9.2
 org.apache.kerby:kerb-core:2.1.1
 org.apache.kerby:kerb-crypto:2.1.1
 org.apache.kerby:kerb-util:2.1.1
@@ -493,8 +493,8 @@ org.apache.pulsar:bouncy-castle-bc:4.0.9
 org.apache.pulsar:pulsar-client-admin-api:4.0.9
 org.apache.pulsar:pulsar-client-api:4.0.9
 org.apache.pulsar:pulsar-client:4.0.9
-org.apache.spark:spark-launcher_2.12:3.5.8
-org.apache.spark:spark-tags_2.12:3.5.8
+org.apache.spark:spark-launcher_2.13:3.5.8
+org.apache.spark:spark-tags_2.13:3.5.8
 org.apache.thrift:libthrift:0.22.0
 org.apache.yetus:audience-annotations:0.15.1
 org.apache.zookeeper:zookeeper-jute:3.9.5
@@ -532,10 +532,10 @@ org.locationtech.proj4j:proj4j:1.2.2
 org.lz4:lz4-java:1.8.0
 org.quartz-scheduler:quartz:2.5.2
 org.roaringbitmap:RoaringBitmap:1.6.12
-org.scala-lang.modules:scala-collection-compat_2.12:2.10.0
-org.scala-lang.modules:scala-java8-compat_2.12:1.0.2
-org.scala-lang:scala-library:2.12.20
-org.scala-lang:scala-reflect:2.12.20
+org.scala-lang.modules:scala-collection-compat_2.13:2.10.0
+org.scala-lang.modules:scala-java8-compat_2.13:1.0.2
+org.scala-lang:scala-library:2.13.18
+org.scala-lang:scala-reflect:2.13.18
 org.slf4j:jcl-over-slf4j:2.0.17
 org.webjars:swagger-ui:5.32.0
 org.xerial.snappy:snappy-java:1.1.10.8

pinot-connectors/pinot-spark-3-connector/pom.xml

@@ -80,7 +80,7 @@
       </properties>
     </profile>
     <profile>
-      <id>scala-2.12</id>
+      <id>scala-build</id>
       <activation>
         <activeByDefault>true</activeByDefault>
       </activation>

pinot-connectors/pinot-spark-common/pom.xml

@@ -35,7 +35,7 @@
 
   <profiles>
     <profile>
-      <id>scala-2.12</id>
+      <id>scala-build</id>
       <activation>
         <activeByDefault>true</activeByDefault>
       </activation>

pinot-connectors/pinot-spark-common/src/test/scala/org/apache/pinot/connector/spark/common/PinotDataSourceWriteOptionsTest.scala

@@ -51,15 +51,7 @@ class PinotDataSourceWriteOptionsTest extends BaseTest {
       Array("col7", "col8")
     )
 
-    pinotDataSourceWriteOptions.tableName shouldEqual expected.tableName
-    pinotDataSourceWriteOptions.segmentNameFormat shouldEqual expected.segmentNameFormat
-    pinotDataSourceWriteOptions.savePath shouldEqual expected.savePath
-    pinotDataSourceWriteOptions.timeColumnName shouldEqual expected.timeColumnName
-    pinotDataSourceWriteOptions.invertedIndexColumns shouldEqual expected.invertedIndexColumns.deep
-    pinotDataSourceWriteOptions.noDictionaryColumns shouldEqual expected.noDictionaryColumns.deep
-    pinotDataSourceWriteOptions.bloomFilterColumns shouldEqual expected.bloomFilterColumns.deep
-    pinotDataSourceWriteOptions.rangeIndexColumns shouldEqual expected.rangeIndexColumns.deep
-
+    assertWriteOptions(pinotDataSourceWriteOptions, expected)
   }
 
   test("Should throw exception if `table` option is missing") {
@@ -121,6 +113,19 @@ class PinotDataSourceWriteOptionsTest extends BaseTest {
       Array.empty
     )
 
-    pinotDataSourceWriteOptions shouldEqual expected
+    assertWriteOptions(pinotDataSourceWriteOptions, expected)
+  }
+
+  private def assertWriteOptions(actual: PinotDataSourceWriteOptions, expected: PinotDataSourceWriteOptions): Unit = {
+    actual.tableName shouldEqual expected.tableName
+    actual.segmentNameFormat shouldEqual expected.segmentNameFormat
+    actual.savePath shouldEqual expected.savePath
+    actual.timeColumnName shouldEqual expected.timeColumnName
+    actual.timeFormat shouldEqual expected.timeFormat
+    actual.timeGranularity shouldEqual expected.timeGranularity
+    actual.invertedIndexColumns.toSeq shouldEqual expected.invertedIndexColumns.toSeq
+    actual.noDictionaryColumns.toSeq shouldEqual expected.noDictionaryColumns.toSeq
+    actual.bloomFilterColumns.toSeq shouldEqual expected.bloomFilterColumns.toSeq
+    actual.rangeIndexColumns.toSeq shouldEqual expected.rangeIndexColumns.toSeq
   }
 }

pinot-plugins/pinot-input-format/pinot-confluent-json/pom.xml

@@ -83,9 +83,9 @@
       <scope>test</scope>
     </dependency>
     <!--
-      VERSION OVERRIDE EXCEPTION: scala-library uses ${scala-2.13.version} instead of the root-managed
-      ${scala.version} (2.12). Confluent's kafka-json-schema-serializer transitively depends on
-      Scala 2.13, so this test dependency must align with Scala 2.13 to avoid binary incompatibility.
+      VERSION OVERRIDE EXCEPTION: Confluent's kafka-json-schema-serializer transitively depends on
+      Scala 2.13, so this test dependency stays pinned to ${scala-2.13.version} even when Pinot is
+      built with -Pscala-2.12.
     -->
     <dependency>
       <groupId>org.scala-lang</groupId>

pom.xml

@@ -266,9 +266,10 @@
     <google.jsr305.version>3.0.2</google.jsr305.version>
 
     <!-- Configuration for Scala -->
-    <scala.version>2.12.20</scala.version>
+    <scala-2.12.version>2.12.20</scala-2.12.version>
     <scala-2.13.version>2.13.18</scala-2.13.version>
-    <scala.compat.version>2.12</scala.compat.version>
+    <scala.version>${scala-2.13.version}</scala.version>
+    <scala.compat.version>2.13</scala.compat.version>
 
     <!-- For Dependency Verifier module -->
     <enforcer-api.version>3.6.2</enforcer-api.version>
@@ -538,13 +539,13 @@
     </profile>
 
     <profile>
-      <id>scala-2.13</id>
+      <id>scala-2.12</id>
       <activation>
         <activeByDefault>false</activeByDefault>
       </activation>
       <properties>
-        <scala.version>2.13.16</scala.version>
-        <scala.compat.version>2.13</scala.compat.version>
+        <scala.version>${scala-2.12.version}</scala.version>
+        <scala.compat.version>2.12</scala.compat.version>
       </properties>
     </profile>
   </profiles>
@@ -2114,7 +2115,7 @@
       </dependency>
       <dependency>
         <groupId>com.twitter</groupId>
-        <artifactId>chill_2.12</artifactId>
+        <artifactId>chill_${scala.compat.version}</artifactId>
         <version>${chill.version}</version>
       </dependency>
       <!-- Used by Spark and quartz -->