Restore broker constructor compat shim; canonicalize normalizer; sunset

Critical fix:
- SegmentPartitionMetadataManager: restore the legacy
  (String tableNameWithType, String partitionColumn, String
  partitionFunctionName, int numPartitions) constructor that existed on
  upstream master. Removing it broke binary compatibility for external
  broker plugins / vendor forks that linked against this signature.
  The shim builds a synthetic ColumnPartitionConfig and delegates to
  the new constructor; expression-mode tables must use the
  ColumnPartitionConfig overloads.

Major fixes:
- ColumnPartitionConfig: canonicalize partitionIdNormalizer to
  uppercase at construction time so downstream comparisons (mix of
  case-sensitive wire format and case-insensitive older comparisons)
  cannot disagree on case alone.
- PartitionFunctionFactory + ColumnPartitionMetadata: add explicit
  "TODO: remove after release 1.7.0" sunset markers to all four
  remaining @deprecated entries on the partition surfaces, matching
  the existing sunset on SegmentPartitionConfig.getFunctionConfig.

Skipped findings (with rationale):
- Broker pruner string-form predicate (CRIT in prior reviews):
  plumbing typed values through requires substantial SPI refactor.
- ByteArrayPartitionFunction normalizer mapping (claimed MASK by
  reviewer): on closer inspection abs(hashCode) % n is the ABS
  pattern (not MASK), so the existing return PartitionIntNormalizer
  .ABS.name() is correct.
- Sentinel rename to "__functionExpr__": the literal
  "FunctionExpr" is now permanent on-the-wire and changing it
  would break test-built segments. The drift regression test already
  guards against future PartitionFunctionType enum collisions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: xiangfu0

pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpartition/SegmentPartitionMetadataManager.java

@@ -75,6 +75,19 @@ public class SegmentPartitionMetadataManager implements SegmentZkMetadataFetchLi
   private transient TablePartitionInfo _tablePartitionInfo;
   private transient TablePartitionReplicatedServersInfo _tablePartitionReplicatedServersInfo;
 
+  /**
+   * Backward-compat shim: the legacy (name-mode-only) constructor used by external broker plugins / vendor forks
+   * that linked against the pre-expression-mode signature. Builds a synthetic {@link ColumnPartitionConfig} and
+   * delegates to the new constructor. Expression-mode tables must use the {@link ColumnPartitionConfig} overloads.
+   * TODO: remove after release 1.7.0 once external callers have migrated.
+   */
+  @Deprecated
+  public SegmentPartitionMetadataManager(String tableNameWithType, String partitionColumn, String partitionFunctionName,
+      int numPartitions) {
+    this(tableNameWithType, partitionColumn,
+        new ColumnPartitionConfig(partitionFunctionName, numPartitions), null);
+  }
+
   public SegmentPartitionMetadataManager(String tableNameWithType, String partitionColumn,
       ColumnPartitionConfig columnPartitionConfig) {
     this(tableNameWithType, partitionColumn, columnPartitionConfig, null);

pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/PartitionFunctionFactory.java

@@ -115,6 +115,7 @@ public static PartitionFunction getPartitionFunction(String functionName, int nu
    * @deprecated Expression-mode configs require a column name to compile the pipeline. This overload throws on
    *     expression-mode configs; prefer {@link #getPartitionFunction(String, ColumnPartitionConfig)} or
    *     {@link #getPartitionFunction(String, ColumnPartitionConfig, FieldSpec)} which support both modes.
+   *     TODO: remove after release 1.7.0.
    * @throws IllegalArgumentException if {@code config.getFunctionExpr()} is non-null.
    */
   @Deprecated
@@ -130,6 +131,7 @@ public static PartitionFunction getPartitionFunction(ColumnPartitionConfig confi
    *
    * @deprecated Expression-mode metadata requires a column name to compile the pipeline. This overload throws on
    *     expression-mode metadata; prefer {@link #getPartitionFunction(String, ColumnPartitionMetadata)}.
+   *     TODO: remove after release 1.7.0.
    * @throws IllegalArgumentException if {@code metadata.getFunctionExpr()} is non-null.
    */
   @Deprecated
@@ -160,7 +162,8 @@ public static PartitionFunction getPartitionFunction(String columnName, ColumnPa
    *
    * @deprecated For BYTES-typed partition columns this overload always compiles the expression pipeline with STRING
    * input, producing partition ids that disagree with ingestion. Prefer
-   * {@link #getPartitionFunction(String, ColumnPartitionConfig, FieldSpec)}.
+   * {@link #getPartitionFunction(String, ColumnPartitionConfig, int, FieldSpec)} (the FieldSpec-aware 4-arg form).
+   * TODO: remove after release 1.7.0.
    */
   @Deprecated
   public static PartitionFunction getPartitionFunction(String columnName, ColumnPartitionConfig columnPartitionConfig,

pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/metadata/ColumnPartitionMetadata.java

@@ -75,6 +75,7 @@ public class ColumnPartitionMetadata {
    * @param functionConfig Configuration required by partition function.
    * @deprecated Use {@link #ColumnPartitionMetadata(PartitionFunction, Set)} instead, which derives all fields
    *             directly from the {@link PartitionFunction} contract and keeps them consistent.
+   *             TODO: remove after release 1.7.0.
    */
   @Deprecated
   public ColumnPartitionMetadata(String functionName, int numPartitions, Set<Integer> partitions,

pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ColumnPartitionConfig.java

@@ -21,6 +21,7 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.base.Preconditions;
+import java.util.Locale;
 import java.util.Map;
 import javax.annotation.Nullable;
 import org.apache.pinot.spi.config.BaseJsonConfig;
@@ -88,7 +89,10 @@ public ColumnPartitionConfig(@JsonProperty("functionName") @Nullable String func
         "Unsupported partitionIdNormalizer: %s", partitionIdNormalizer);
     _functionName = functionName;
     _functionExpr = functionExpr;
-    _partitionIdNormalizer = partitionIdNormalizer;
+    // Canonicalize to uppercase at construction so downstream comparisons (case-sensitive on the wire format,
+    // case-insensitive in older code paths) cannot disagree on case alone.
+    _partitionIdNormalizer = hasText(partitionIdNormalizer)
+        ? partitionIdNormalizer.trim().toUpperCase(Locale.ROOT) : null;
     _numPartitions = numPartitions;
     _functionConfig = functionConfig;
   }