Skip to content

Add timeout overflow break handling at leaf stage#17216

Open
xiangfu0 wants to merge 1 commit into
apache:masterfrom
xiangfu0:feature/timeout-overflow-leaf
Open

Add timeout overflow break handling at leaf stage#17216
xiangfu0 wants to merge 1 commit into
apache:masterfrom
xiangfu0:feature/timeout-overflow-leaf

Conversation

@xiangfu0

@xiangfu0 xiangfu0 commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

Summary

  • introduce timeoutOverflowMode plumbing in server/broker metadata
  • make LeafOperator break early only if mode=BREAK and expose a TIMEOUT_OVERFLOW_REACHED stat so intermediates keep running
  • add SlowMockInstanceDataManagerFactory plus TimeoutOverflowQueryRunnerTest to cover simple select, join, and aggregation cases

query with partial results
image
query with full results
image

@codecov-commenter

codecov-commenter commented Nov 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.95745% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.11%. Comparing base (2892236) to head (f89cfe7).

Files with missing lines Patch % Lines
...pinot/query/runtime/operator/BaseJoinOperator.java 28.57% 16 Missing and 4 partials ⚠️
...che/pinot/query/runtime/operator/LeafOperator.java 71.42% 7 Missing and 5 partials ⚠️
...va/org/apache/pinot/query/runtime/QueryRunner.java 80.43% 4 Missing and 5 partials ⚠️
...common/response/broker/BrokerResponseNativeV2.java 70.00% 1 Missing and 2 partials ⚠️
...not/query/runtime/operator/MultiStageOperator.java 71.42% 1 Missing and 1 partial ⚠️
...va/org/apache/pinot/spi/utils/CommonConstants.java 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2892236) and HEAD (f89cfe7). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (2892236) HEAD (f89cfe7)
unittests 2 1
java-25 5 1
temurin 5 1
integration 3 0
integration2 1 0
integration1 1 0
custom-integration1 1 0
unittests2 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17216      +/-   ##
============================================
- Coverage     65.39%   57.11%   -8.28%     
+ Complexity     1405        1    -1404     
============================================
  Files          3423     2626     -797     
  Lines        215968   156436   -59532     
  Branches      34186    25557    -8629     
============================================
- Hits         141228    89351   -51877     
+ Misses        63380    59449    -3931     
+ Partials      11360     7636    -3724     
Flag Coverage Δ
custom-integration1 ?
integration ?
integration1 ?
integration2 ?
java-25 57.11% <65.95%> (-8.28%) ⬇️
temurin 57.11% <65.95%> (-8.28%) ⬇️
unittests 57.11% <65.95%> (-8.28%) ⬇️
unittests1 57.11% <65.95%> (-0.01%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiangfu0
xiangfu0 force-pushed the feature/timeout-overflow-leaf branch 3 times, most recently from 53029b6 to d04720b Compare November 17, 2025 08:35
@xiangfu0
xiangfu0 marked this pull request as ready for review November 17, 2025 09:31
@xiangfu0
xiangfu0 requested a review from Copilot November 17, 2025 09:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@xiangfu0
xiangfu0 force-pushed the feature/timeout-overflow-leaf branch 2 times, most recently from 04d6211 to ccaacce Compare November 17, 2025 13:04
@xiangfu0
xiangfu0 force-pushed the feature/timeout-overflow-leaf branch 2 times, most recently from aa35571 to 6d5f1d9 Compare July 19, 2026 08:10
@xiangfu0
xiangfu0 force-pushed the feature/timeout-overflow-leaf branch from 6d5f1d9 to f89cfe7 Compare July 20, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants