Reject path traversal filenames during HMEF attachment extraction#1066
Open
jmestwa-coder wants to merge 1 commit into
Open
Reject path traversal filenames during HMEF attachment extraction#1066jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
pjfanning
reviewed
May 12, 2026
| private static File getOutputFile(File dir, String filename) throws IOException { | ||
| Path outputDir = dir.toPath().toAbsolutePath().normalize(); | ||
| Path outputFile = outputDir.resolve(filename).normalize(); | ||
| if (!outputFile.startsWith(outputDir)) { |
Member
There was a problem hiding this comment.
Can you have a look at
and adjust that to have a shared method to do this check? Code reuse is important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject attachment filenames that would escape the selected extraction directory during HMEF/TNEF attachment extraction.
Previously, attachment filenames from TNEF metadata were written directly using:
This allowed traversal-style filenames such as
../escaped.txtto resolve outside the intended extraction directory.Changes
Test
Added a regression test that:
IOException